diff mbox series

[2/7] dt-bindings: arm: aspeed: document board compatibles

Message ID 20220529104928.79636-2-krzysztof.kozlowski@linaro.org
State Accepted
Commit f77024c8014766575db03c3c2d904299af43607e
Headers show
Series [1/7] dt-bindings: vendor-prefixes: document several vendors for Aspeed BMC boards | expand

Commit Message

Krzysztof Kozlowski May 29, 2022, 10:49 a.m. UTC
Document all compatibles used in existing upstreamed Aspeed AST2400,
AST2500 and AST2600 based boards.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../bindings/arm/aspeed/aspeed.yaml           | 83 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 84 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml

Comments

Joel Stanley June 23, 2022, 5:36 a.m. UTC | #1
On Mon, 20 Jun 2022 at 11:06, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 29/05/2022 12:49, Krzysztof Kozlowski wrote:
> > Document all compatibles used in existing upstreamed Aspeed AST2400,
> > AST2500 and AST2600 based boards.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> >  .../bindings/arm/aspeed/aspeed.yaml           | 83 +++++++++++++++++++
> >  MAINTAINERS                                   |  1 +
> >  2 files changed, 84 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>
> Joel, Andrew,
>
> Any comments on the series? Rob applied only patch 1, so the rest is
> supposed through Aspeed tree. Shall I pick them up and send to arm-soc?

I will take a look at them when it's time to send patches for the next
kernel release.

They should go through the aspeed tree like the rest of the aspeed
device tree patches.

Thanks,

Joel

>
> Best regards,
> Krzysztof
Krzysztof Kozlowski June 23, 2022, 7:10 a.m. UTC | #2
On 23/06/2022 07:36, Joel Stanley wrote:
> On Mon, 20 Jun 2022 at 11:06, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 29/05/2022 12:49, Krzysztof Kozlowski wrote:
>>> Document all compatibles used in existing upstreamed Aspeed AST2400,
>>> AST2500 and AST2600 based boards.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>>  .../bindings/arm/aspeed/aspeed.yaml           | 83 +++++++++++++++++++
>>>  MAINTAINERS                                   |  1 +
>>>  2 files changed, 84 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>>
>> Joel, Andrew,
>>
>> Any comments on the series? Rob applied only patch 1, so the rest is
>> supposed through Aspeed tree. Shall I pick them up and send to arm-soc?
> 
> I will take a look at them when it's time to send patches for the next
> kernel release.

But that's not how the next development works. Patches, if proper/good,
should be applied in some reasonable amount of time and then sit in
maintainers tree. This way the patches will be in linux-next, assuming
that maintainer correctly added it to linux-next. All other people can
then easily base their work on linux-next or maintainer's tree and
continue their development.

Waiting with the patches till time to intreract with arm-soc (usually
some late in the cycle, like rc5-rc6), not providing review, does not
allow other people to see accepted contributions and base the work on them.

Really, there is no single reason to hold on patches till there is time
to send them to arm-soc. It's the first time I hear something like this
about SoC or any other tree.

> 
> They should go through the aspeed tree like the rest of the aspeed
> device tree patches.

Of course, but somehow they were not going...

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
new file mode 100644
index 000000000000..f214b57d5ae1
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -0,0 +1,83 @@ 
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/aspeed/aspeed.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Aspeed SoC based boards
+
+maintainers:
+  - Joel Stanley <joel@jms.id.au>
+
+properties:
+  $nodename:
+    const: '/'
+  compatible:
+    oneOf:
+      - description: AST2400 based boards
+        items:
+          - enum:
+              - facebook,galaxy100-bmc
+              - facebook,wedge100-bmc
+              - facebook,wedge40-bmc
+              - microsoft,olympus-bmc
+              - quanta,q71l-bmc
+              - tyan,palmetto-bmc
+              - yadro,vesnin-bmc
+          - const: aspeed,ast2400
+
+      - description: AST2500 based boards
+        items:
+          - enum:
+              - amd,ethanolx-bmc
+              - ampere,mtjade-bmc
+              - asrock,e3c246d4i-bmc
+              - asrock,romed8hm3-bmc
+              - bytedance,g220a-bmc
+              - facebook,cmm-bmc
+              - facebook,minipack-bmc
+              - facebook,tiogapass-bmc
+              - facebook,yamp-bmc
+              - facebook,yosemitev2-bmc
+              - facebook,wedge400-bmc
+              - hxt,stardragon4800-rep2-bmc
+              - ibm,mihawk-bmc
+              - ibm,mowgli-bmc
+              - ibm,romulus-bmc
+              - ibm,swift-bmc
+              - ibm,witherspoon-bmc
+              - ingrasys,zaius-bmc
+              - inspur,fp5280g2-bmc
+              - inspur,nf5280m6-bmc
+              - inspur,on5263m5-bmc
+              - intel,s2600wf-bmc
+              - inventec,lanyang-bmc
+              - lenovo,hr630-bmc
+              - lenovo,hr855xg2-bmc
+              - portwell,neptune-bmc
+              - qcom,centriq2400-rep-bmc
+              - supermicro,x11spi-bmc
+              - tyan,s7106-bmc
+              - tyan,s8036-bmc
+              - yadro,nicole-bmc
+              - yadro,vegman-n110-bmc
+              - yadro,vegman-rx20-bmc
+              - yadro,vegman-sx20-bmc
+          - const: aspeed,ast2500
+
+      - description: AST2600 based boards
+        items:
+          - enum:
+              - facebook,bletchley-bmc
+              - facebook,cloudripper-bmc
+              - facebook,elbert-bmc
+              - facebook,fuji-bmc
+              - ibm,everest-bmc
+              - ibm,rainier-bmc
+              - ibm,tacoma-bmc
+              - inventec,transformer-bmc
+              - nuvia,dc-scm-bmc
+              - quanta,s6q-bmc
+          - const: aspeed,ast2600
+
+additionalProperties: true
diff --git a/MAINTAINERS b/MAINTAINERS
index c71276d7752e..860017ff41a8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1896,6 +1896,7 @@  L:	linux-aspeed@lists.ozlabs.org (moderated for non-subscribers)
 S:	Supported
 Q:	https://patchwork.ozlabs.org/project/linux-aspeed/list/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git
+F:	Documentation/devicetree/bindings/arm/aspeed/
 F:	arch/arm/boot/dts/aspeed-*
 F:	arch/arm/mach-aspeed/
 N:	aspeed