| Message ID | 20220602071448.277968-1-chi.minghao@zte.com.cn |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: imx-audmux: remove unnecessary check of clk_disable_unprepare | expand |
On Thu, Jun 2, 2022 at 3:14 PM <cgel.zte@gmail.com> wrote: > From: Minghao Chi <chi.minghao@zte.com.cn> > > Because clk_disable_unprepare already checked NULL clock > parameter, so the additional checks are unnecessary, just remove them. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> > --- > sound/soc/fsl/imx-audmux.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c > index dfa05d40b276..f434fa7decc1 100644 > --- a/sound/soc/fsl/imx-audmux.c > +++ b/sound/soc/fsl/imx-audmux.c > @@ -71,8 +71,7 @@ static ssize_t audmux_read_file(struct file *file, char > __user *user_buf, > ptcr = readl(audmux_base + IMX_AUDMUX_V2_PTCR(port)); > pdcr = readl(audmux_base + IMX_AUDMUX_V2_PDCR(port)); > > - if (audmux_clk) > - clk_disable_unprepare(audmux_clk); > + clk_disable_unprepare(audmux_clk); > I think the check of audmux_clk before "clk_prepare_enable" also can be removed? > buf = kmalloc(PAGE_SIZE, GFP_KERNEL); > if (!buf) > @@ -218,8 +217,7 @@ int imx_audmux_v2_configure_port(unsigned int port, > unsigned int ptcr, > writel(ptcr, audmux_base + IMX_AUDMUX_V2_PTCR(port)); > writel(pdcr, audmux_base + IMX_AUDMUX_V2_PDCR(port)); > > - if (audmux_clk) > - clk_disable_unprepare(audmux_clk); > + clk_disable_unprepare(audmux_clk); > ditto best regards wang shengjiu > > return 0; > } > -- > 2.25.1 > > >
diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c index dfa05d40b276..f434fa7decc1 100644 --- a/sound/soc/fsl/imx-audmux.c +++ b/sound/soc/fsl/imx-audmux.c @@ -71,8 +71,7 @@ static ssize_t audmux_read_file(struct file *file, char __user *user_buf, ptcr = readl(audmux_base + IMX_AUDMUX_V2_PTCR(port)); pdcr = readl(audmux_base + IMX_AUDMUX_V2_PDCR(port)); - if (audmux_clk) - clk_disable_unprepare(audmux_clk); + clk_disable_unprepare(audmux_clk); buf = kmalloc(PAGE_SIZE, GFP_KERNEL); if (!buf) @@ -218,8 +217,7 @@ int imx_audmux_v2_configure_port(unsigned int port, unsigned int ptcr, writel(ptcr, audmux_base + IMX_AUDMUX_V2_PTCR(port)); writel(pdcr, audmux_base + IMX_AUDMUX_V2_PDCR(port)); - if (audmux_clk) - clk_disable_unprepare(audmux_clk); + clk_disable_unprepare(audmux_clk); return 0; }