[v5,7/7] sparc64: mm/gup: add gup trace points

Message ID 1449696151-4195-8-git-send-email-yang.shi@linaro.org
State New
Headers show

Commit Message

Yang Shi Dec. 9, 2015, 9:22 p.m.
Cc: "David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
Signed-off-by: Yang Shi <yang.shi@linaro.org>

---
 arch/sparc/mm/gup.c | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.0.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Comments

Yang Shi Jan. 13, 2016, 6:13 p.m. | #1
Hi David,

Any comment on this one? The tracing part review has been done.

Thanks,
Yang


On 12/9/2015 1:22 PM, Yang Shi wrote:
> Cc: "David S. Miller" <davem@davemloft.net>

> Cc: sparclinux@vger.kernel.org

> Signed-off-by: Yang Shi <yang.shi@linaro.org>

> ---

>   arch/sparc/mm/gup.c | 6 ++++++

>   1 file changed, 6 insertions(+)

>

> diff --git a/arch/sparc/mm/gup.c b/arch/sparc/mm/gup.c

> index 2e5c4fc..5a06c34 100644

> --- a/arch/sparc/mm/gup.c

> +++ b/arch/sparc/mm/gup.c

> @@ -12,6 +12,8 @@

>   #include <linux/rwsem.h>

>   #include <asm/pgtable.h>

>

> +#include <trace/events/gup.h>

> +

>   /*

>    * The performance critical leaf functions are made noinline otherwise gcc

>    * inlines everything into a single function which results in too much

> @@ -174,6 +176,8 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write,

>   	len = (unsigned long) nr_pages << PAGE_SHIFT;

>   	end = start + len;

>

> +	trace_gup_get_user_pages_fast(start, nr_pages);

> +

>   	local_irq_save(flags);

>   	pgdp = pgd_offset(mm, addr);

>   	do {

> @@ -236,6 +240,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write,

>

>   	local_irq_enable();

>

> +	trace_gup_get_user_pages_fast(start, nr_pages);

> +

>   	VM_BUG_ON(nr != (end - start) >> PAGE_SHIFT);

>   	return nr;

>

>
David Miller Jan. 13, 2016, 8:21 p.m. | #2
From: "Shi, Yang" <yang.shi@linaro.org>

Date: Wed, 13 Jan 2016 10:13:08 -0800

> Any comment on this one? The tracing part review has been done.


I thought this was going to simply be submitted upstream via
another tree.

If you just want my ack then:

Acked-by: David S. Miller <davem@davemloft.net>

Patch

diff --git a/arch/sparc/mm/gup.c b/arch/sparc/mm/gup.c
index 2e5c4fc..5a06c34 100644
--- a/arch/sparc/mm/gup.c
+++ b/arch/sparc/mm/gup.c
@@ -12,6 +12,8 @@ 
 #include <linux/rwsem.h>
 #include <asm/pgtable.h>
 
+#include <trace/events/gup.h>
+
 /*
  * The performance critical leaf functions are made noinline otherwise gcc
  * inlines everything into a single function which results in too much
@@ -174,6 +176,8 @@  int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
 	len = (unsigned long) nr_pages << PAGE_SHIFT;
 	end = start + len;
 
+	trace_gup_get_user_pages_fast(start, nr_pages);
+
 	local_irq_save(flags);
 	pgdp = pgd_offset(mm, addr);
 	do {
@@ -236,6 +240,8 @@  int get_user_pages_fast(unsigned long start, int nr_pages, int write,
 
 	local_irq_enable();
 
+	trace_gup_get_user_pages_fast(start, nr_pages);
+
 	VM_BUG_ON(nr != (end - start) >> PAGE_SHIFT);
 	return nr;