| Message ID | 1449773929-15257-1-git-send-email-zoltan.kiss@linaro.org |
|---|---|
| State | Accepted |
| Commit | 0510f63fb88d603dd1d2d312c40fb58af2922698 |
| Headers | show |
On Thu, Dec 10, 2015 at 12:58 PM, Zoltan Kiss <zoltan.kiss@linaro.org> wrote: > This could help the existing configuration methods to be used if the > application prefers that. The platform_params should always supersede that > though. > > Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > > v2: improve wording about superseding > > include/odp/api/init.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/odp/api/init.h b/include/odp/api/init.h > index 737ff6d..4ac5216 100644 > --- a/include/odp/api/init.h > +++ b/include/odp/api/init.h > @@ -141,6 +141,10 @@ typedef struct odp_platform_init_t { > * > * This function must be called once before calling any other ODP API > * functions. > + * The underlying implementation may have another way to get configuration > + * related to platform_params (e.g. environmental variable, configuration > + * file), but if the application passes platform_params, it should always > + * supersede any other configuration data the platform has. > * > * @param params Those parameters that are interpreted by the > ODP API. > * Use NULL to set all parameters to their > defaults. > -- > 1.9.1 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
Merged, Maxim. On 12/11/2015 10:35, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> > > >> -----Original Message----- >> From: EXT Zoltan Kiss [mailto:zoltan.kiss@linaro.org] >> Sent: Thursday, December 10, 2015 8:59 PM >> To: lng-odp@lists.linaro.org >> Cc: Savolainen, Petri (Nokia - FI/Espoo) >> Subject: [API-NEXT PATCH v2] api: init: allow implementation to use >> private ways for its own configuration >> >> This could help the existing configuration methods to be used if the >> application prefers that. The platform_params should always supersede that >> though. >> >> Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org> >> --- >> >> v2: improve wording about superseding >> >> include/odp/api/init.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/include/odp/api/init.h b/include/odp/api/init.h >> index 737ff6d..4ac5216 100644 >> --- a/include/odp/api/init.h >> +++ b/include/odp/api/init.h >> @@ -141,6 +141,10 @@ typedef struct odp_platform_init_t { >> * >> * This function must be called once before calling any other ODP API >> * functions. >> + * The underlying implementation may have another way to get >> configuration >> + * related to platform_params (e.g. environmental variable, configuration >> + * file), but if the application passes platform_params, it should always >> + * supersede any other configuration data the platform has. >> * >> * @param params Those parameters that are interpreted by the >> ODP API. >> * Use NULL to set all parameters to their >> defaults. >> -- >> 1.9.1 > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
diff --git a/include/odp/api/init.h b/include/odp/api/init.h index 737ff6d..4ac5216 100644 --- a/include/odp/api/init.h +++ b/include/odp/api/init.h @@ -141,6 +141,10 @@ typedef struct odp_platform_init_t { * * This function must be called once before calling any other ODP API * functions. + * The underlying implementation may have another way to get configuration + * related to platform_params (e.g. environmental variable, configuration + * file), but if the application passes platform_params, it should always + * supersede any other configuration data the platform has. * * @param params Those parameters that are interpreted by the ODP API. * Use NULL to set all parameters to their defaults.
This could help the existing configuration methods to be used if the application prefers that. The platform_params should always supersede that though. Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org> --- v2: improve wording about superseding include/odp/api/init.h | 4 ++++ 1 file changed, 4 insertions(+)