| Message ID | 1449830880-15319-3-git-send-email-zhang.chunyan@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hi Alex, Is there any problem on this patch, I noticed that you lost this patch when you sent a patchset to Greg for 4.4 merge. Thanks, Chunyan On Fri, Dec 11, 2015 at 6:48 PM, Chunyan Zhang <zhang.chunyan@linaro.org> wrote: > sw_end represents the last software master, sw_start is index of the > first master, so the number of software masters should be > sw_end - sw_start + 1. > > Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org> > --- > drivers/hwtracing/intel_th/sth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/intel_th/sth.c b/drivers/hwtracing/intel_th/sth.c > index 56101c3..28917d7 100644 > --- a/drivers/hwtracing/intel_th/sth.c > +++ b/drivers/hwtracing/intel_th/sth.c > @@ -173,7 +173,7 @@ static int intel_th_sw_init(struct sth_device *sth) > sth->stm.sw_start = reg & 0xffff; > sth->stm.sw_end = reg >> 16; > > - sth->sw_nmasters = sth->stm.sw_end - sth->stm.sw_start; > + sth->sw_nmasters = sth->stm.sw_end - sth->stm.sw_start + 1; > dev_dbg(sth->dev, "sw_start: %x sw_end: %x masters: %x nchannels: %x\n", > sth->stm.sw_start, sth->stm.sw_end, sth->sw_nmasters, > sth->stm.sw_nchannels); > -- > 1.9.1 >
On Thu, Jan 28, 2016 at 6:16 PM, Alexander Shishkin <alexander.shishkin@linux.intel.com> wrote: > Chunyan Zhang <zhang.chunyan@linaro.org> writes: > >> Hi Alex, > > Hi chunyan, > >> Is there any problem on this patch, I noticed that you lost this patch >> when you sent a patchset to Greg for 4.4 merge. > > No, there isn't, it just doesn't fix anything important to be sent > outside of merge window, but the other one does. I'll queue this one up > for the next merge window. > > Well, actually, one thing, since you brought it up: can you fix the > commit message to be more in line with commit message guidelines? There Sure, I'll do. Thanks, Chunyan > are many articles/blog posts on the internet that explain what and why > should be mentioned in a commit message. > > Thanks, > -- > Alex
diff --git a/drivers/hwtracing/intel_th/sth.c b/drivers/hwtracing/intel_th/sth.c index 56101c3..28917d7 100644 --- a/drivers/hwtracing/intel_th/sth.c +++ b/drivers/hwtracing/intel_th/sth.c @@ -173,7 +173,7 @@ static int intel_th_sw_init(struct sth_device *sth) sth->stm.sw_start = reg & 0xffff; sth->stm.sw_end = reg >> 16; - sth->sw_nmasters = sth->stm.sw_end - sth->stm.sw_start; + sth->sw_nmasters = sth->stm.sw_end - sth->stm.sw_start + 1; dev_dbg(sth->dev, "sw_start: %x sw_end: %x masters: %x nchannels: %x\n", sth->stm.sw_start, sth->stm.sw_end, sth->sw_nmasters, sth->stm.sw_nchannels);
sw_end represents the last software master, sw_start is index of the first master, so the number of software masters should be sw_end - sw_start + 1. Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org> --- drivers/hwtracing/intel_th/sth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/