diff mbox series

[v1] ARM: dts: am33xx: Fix MMCHS0 dma properties

Message ID 20220620121900.5196-1-mtwget@gmail.com
State Superseded
Headers show
Series [v1] ARM: dts: am33xx: Fix MMCHS0 dma properties | expand

Commit Message

Yu-Tung Chang June 20, 2022, 12:19 p.m. UTC
According to technical manual(table 11-24), the DMA of MMCHS0 should be
direct mapped.

Signed-off-by: YuTong Chang <mtwget@gmail.com>
---
v1: Cleaned up coding style and addressed review comments

 arch/arm/boot/dts/am33xx-l4.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Krzysztof Kozlowski June 20, 2022, 12:32 p.m. UTC | #1
On 20/06/2022 14:19, YuTong Chang wrote:
> According to technical manual(table 11-24), the DMA of MMCHS0 should be
> direct mapped.
> 
> Signed-off-by: YuTong Chang <mtwget@gmail.com>

This should be v2, not v1. You already sent a v1.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


> ---
> v1: Cleaned up coding style and addressed review comments
> 
>  arch/arm/boot/dts/am33xx-l4.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
> index 7da42a5b959c..7e50fe633d8a 100644
> --- a/arch/arm/boot/dts/am33xx-l4.dtsi
> +++ b/arch/arm/boot/dts/am33xx-l4.dtsi
> @@ -1502,8 +1502,7 @@ SYSC_OMAP2_SOFTRESET |
>  			mmc1: mmc@0 {
>  				compatible = "ti,am335-sdhci";
>  				ti,needs-special-reset;
> -				dmas = <&edma_xbar 24 0 0
> -					&edma_xbar 25 0 0>;
> +				dmas = <&edma 24 0>, <&edma 25 0>;
>  				dma-names = "tx", "rx";
>  				interrupts = <64>;
>  				reg = <0x0 0x1000>;


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
index 7da42a5b959c..7e50fe633d8a 100644
--- a/arch/arm/boot/dts/am33xx-l4.dtsi
+++ b/arch/arm/boot/dts/am33xx-l4.dtsi
@@ -1502,8 +1502,7 @@  SYSC_OMAP2_SOFTRESET |
 			mmc1: mmc@0 {
 				compatible = "ti,am335-sdhci";
 				ti,needs-special-reset;
-				dmas = <&edma_xbar 24 0 0
-					&edma_xbar 25 0 0>;
+				dmas = <&edma 24 0>, <&edma 25 0>;
 				dma-names = "tx", "rx";
 				interrupts = <64>;
 				reg = <0x0 0x1000>;