diff mbox

[API-NEXT] api: remove ODP_DEPRECATED

Message ID 1450202766-30096-1-git-send-email-mike.holmes@linaro.org
State New
Headers show

Commit Message

Mike Holmes Dec. 15, 2015, 6:06 p.m. UTC
The deprecation mechanism should not break the build.
Remove this definition because the doxygen deprecated flag will be used
directly.

Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
 include/odp/api/hints.h | 5 -----
 1 file changed, 5 deletions(-)

Comments

Bill Fischofer Dec. 15, 2015, 11:21 p.m. UTC | #1
On Tue, Dec 15, 2015 at 12:06 PM, Mike Holmes <mike.holmes@linaro.org>
wrote:

> The deprecation mechanism should not break the build.

> Remove this definition because the doxygen deprecated flag will be used

> directly.

>

> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>

>


Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>



> ---

>  include/odp/api/hints.h | 5 -----

>  1 file changed, 5 deletions(-)

>

> diff --git a/include/odp/api/hints.h b/include/odp/api/hints.h

> index ea67fc4..b117ed3 100644

> --- a/include/odp/api/hints.h

> +++ b/include/odp/api/hints.h

> @@ -51,11 +51,6 @@ extern "C" {

>  #define ODP_PRINTF_FORMAT(x, y) __attribute__((format(printf, (x), (y))))

>

>  /**

> - * Indicate deprecated variables, functions or types

> - */

> -#define ODP_DEPRECATED __attribute__((__deprecated__))

> -

> -/**

>   * Intentionally unused variables ot functions

>

Not part of your patch, but s/ot/or should be a separate nit patch.


>   */

>  #define ODP_UNUSED     __attribute__((__unused__))

> --

> 2.5.0

>

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp

>
Maxim Uvarov Dec. 16, 2015, 10:29 a.m. UTC | #2
To not break a build just add CFLAGS="-Wno-deprecated-declarations".
That will be good check that no more deprecated function exist in the code.

I.e. procedure is following functions will have ODP_DEPRECATED tag for some
tome and ./configure will support -Wno-deprecated-declarations as default.
And some option like --without-depricated to build clean build. That way 
we can easy
find that our code is free from deprecated things.

Even might be masted will not disable that warning in any time. But some 
stable branch
will disable deprecated warnings and have some deprecated functions.

Best regards,
Maxim.


On 12/15/2015 21:06, Mike Holmes wrote:
> The deprecation mechanism should not break the build.
> Remove this definition because the doxygen deprecated flag will be used
> directly.
>
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> ---
>   include/odp/api/hints.h | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/include/odp/api/hints.h b/include/odp/api/hints.h
> index ea67fc4..b117ed3 100644
> --- a/include/odp/api/hints.h
> +++ b/include/odp/api/hints.h
> @@ -51,11 +51,6 @@ extern "C" {
>   #define ODP_PRINTF_FORMAT(x, y) __attribute__((format(printf, (x), (y))))
>   
>   /**
> - * Indicate deprecated variables, functions or types
> - */
> -#define ODP_DEPRECATED __attribute__((__deprecated__))
> -
> -/**
>    * Intentionally unused variables ot functions
>    */
>   #define ODP_UNUSED     __attribute__((__unused__))
diff mbox

Patch

diff --git a/include/odp/api/hints.h b/include/odp/api/hints.h
index ea67fc4..b117ed3 100644
--- a/include/odp/api/hints.h
+++ b/include/odp/api/hints.h
@@ -51,11 +51,6 @@  extern "C" {
 #define ODP_PRINTF_FORMAT(x, y) __attribute__((format(printf, (x), (y))))
 
 /**
- * Indicate deprecated variables, functions or types
- */
-#define ODP_DEPRECATED __attribute__((__deprecated__))
-
-/**
  * Intentionally unused variables ot functions
  */
 #define ODP_UNUSED     __attribute__((__unused__))