diff mbox

[20/54] gpio: tz1090: Be sure to clamp return value

Message ID 1450794266-23370-1-git-send-email-linus.walleij@linaro.org
State Accepted
Commit 9fa90796244aa6043d59c8e127845ff9e3b01485
Headers show

Commit Message

Linus Walleij Dec. 22, 2015, 2:24 p.m. UTC
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 drivers/gpio/gpio-tz1090.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpio/gpio-tz1090.c b/drivers/gpio/gpio-tz1090.c
index 79ef6e1ce568..a4a822542ac1 100644
--- a/drivers/gpio/gpio-tz1090.c
+++ b/drivers/gpio/gpio-tz1090.c
@@ -214,7 +214,7 @@  static int tz1090_gpio_get(struct gpio_chip *chip, unsigned int offset)
 {
 	struct tz1090_gpio_bank *bank = to_bank(chip);
 
-	return tz1090_gpio_read_bit(bank, REG_GPIO_DIN, offset);
+	return !!tz1090_gpio_read_bit(bank, REG_GPIO_DIN, offset);
 }
 
 /*