| Message ID | 20220709141940.836412-1-Perry.Yuan@amd.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,01/14] x86/msr: Add the MSR definition for AMD CPPC hardware control. | expand |
On 09-07-22, 10:19, Perry Yuan wrote: > "cpufreq_cpu_release" and "cpufreq_cpu_acquire" are only used internally by > drivers/cpufreq/cpufreq.c currently. > Export them so that other drivers such as the AMD P-state driver can use them as well. I don't see your driver using them, what am I missing ?
[AMD Official Use Only - General] Hi Viresh: > -----Original Message----- > From: Viresh Kumar <viresh.kumar@linaro.org> > Sent: Monday, July 11, 2022 8:40 AM > To: Yuan, Perry <Perry.Yuan@amd.com> > Cc: rafael.j.wysocki@intel.com; Huang, Ray <Ray.Huang@amd.com>; > Sharma, Deepak <Deepak.Sharma@amd.com>; Limonciello, Mario > <Mario.Limonciello@amd.com>; Fontenot, Nathan > <Nathan.Fontenot@amd.com>; Deucher, Alexander > <Alexander.Deucher@amd.com>; Su, Jinzhou (Joe) <Jinzhou.Su@amd.com>; > Huang, Shimmer <Shimmer.Huang@amd.com>; Du, Xiaojian > <Xiaojian.Du@amd.com>; Meng, Li (Jassmine) <Li.Meng@amd.com>; linux- > pm@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 10/14] cpufreq: cpufreq: export cpufreq cpu release > and acquire > > [CAUTION: External Email] > > On 09-07-22, 10:19, Perry Yuan wrote: > > "cpufreq_cpu_release" and "cpufreq_cpu_acquire" are only used > > internally by drivers/cpufreq/cpufreq.c currently. > > Export them so that other drivers such as the AMD P-state driver can use > them as well. > > I don't see your driver using them, what am I missing ? > > -- > viresh The amd-pstate for EPP mode is under testing, I will push that patchset in a few days for reviewing. If this patch makes confusing, maybe I need to move this patch to coming patchset. Perry.
On 11-07-22, 01:39, Yuan, Perry wrote: > The amd-pstate for EPP mode is under testing, I will push that patchset in a few days for reviewing. > If this patch makes confusing, maybe I need to move this patch to coming patchset. Yeah, it should come with users and not like this.
[AMD Official Use Only - General] Hi Viresh, > -----Original Message----- > From: Viresh Kumar <viresh.kumar@linaro.org> > Sent: Monday, July 11, 2022 9:40 AM > To: Yuan, Perry <Perry.Yuan@amd.com> > Cc: rafael.j.wysocki@intel.com; Huang, Ray <Ray.Huang@amd.com>; > Sharma, Deepak <Deepak.Sharma@amd.com>; Limonciello, Mario > <Mario.Limonciello@amd.com>; Fontenot, Nathan > <Nathan.Fontenot@amd.com>; Deucher, Alexander > <Alexander.Deucher@amd.com>; Su, Jinzhou (Joe) <Jinzhou.Su@amd.com>; > Huang, Shimmer <Shimmer.Huang@amd.com>; Du, Xiaojian > <Xiaojian.Du@amd.com>; Meng, Li (Jassmine) <Li.Meng@amd.com>; linux- > pm@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 10/14] cpufreq: cpufreq: export cpufreq cpu release > and acquire > > [CAUTION: External Email] > > On 11-07-22, 01:39, Yuan, Perry wrote: > > The amd-pstate for EPP mode is under testing, I will push that patchset in > a few days for reviewing. > > If this patch makes confusing, maybe I need to move this patch to coming > patchset. > > Yeah, it should come with users and not like this. > > -- > viresh Thanks a lot for your feedback Will remove this patch from current patchset in V3. Perry.
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 73432360e6e9..4d3c83da29b7 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -262,6 +262,7 @@ void cpufreq_cpu_release(struct cpufreq_policy *policy) cpufreq_cpu_put(policy); } +EXPORT_SYMBOL_GPL(cpufreq_cpu_release); /** * cpufreq_cpu_acquire - Find policy for a CPU, mark it as busy and lock it. @@ -291,6 +292,7 @@ struct cpufreq_policy *cpufreq_cpu_acquire(unsigned int cpu) return policy; } +EXPORT_SYMBOL_GPL(cpufreq_cpu_acquire); /********************************************************************* * EXTERNALLY AFFECTING FREQUENCY CHANGES *
"cpufreq_cpu_release" and "cpufreq_cpu_acquire" are only used internally by drivers/cpufreq/cpufreq.c currently. Export them so that other drivers such as the AMD P-state driver can use them as well. Signed-off-by: Perry Yuan <Perry.Yuan@amd.com> --- drivers/cpufreq/cpufreq.c | 2 ++ 1 file changed, 2 insertions(+)