diff mbox series

[1/1] scsi: ufs: fix missing clk change notification on host reset

Message ID 20220711144224.17916-2-powen.kao@mediatek.com
State New
Headers show
Series [1/1] scsi: ufs: fix missing clk change notification on host reset | expand

Commit Message

Po-Wen Kao July 11, 2022, 2:42 p.m. UTC
In ufshcd_host_reset_and_restore(), ufshcd_set_clk_freq() is called
to scale clk rate. However, this did not call vops->clk_scale_notify()
to inform platform driver of clk change.

We propose to call on ufshcd_scale_clks() instead so that clk change
can be properly handled.

Signed-off-by: Po-Wen Kao <powen.kao@mediatek.com>
---
 drivers/scsi/ufs/ufshcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen July 14, 2022, 4:22 a.m. UTC | #1
On Mon, 11 Jul 2022 22:42:23 +0800, Po-Wen Kao wrote:

> In ufshcd_host_reset_and_restore(), ufshcd_set_clk_freq() is called
> to scale clk rate. However, this did not call vops->clk_scale_notify()
> to inform platform driver of clk change.
> 
> We propose to call on ufshcd_scale_clks() instead so that clk change
> can be properly handled.
> 
> [...]

Applied to 5.19/scsi-fixes, thanks!

[1/1] scsi: ufs: fix missing clk change notification on host reset
      https://git.kernel.org/mkp/scsi/c/52a518019ca1
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 3f9caafa91bf..3e7af7b11d2e 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -7230,7 +7230,7 @@  static int ufshcd_host_reset_and_restore(struct ufs_hba *hba)
 	hba->silence_err_logs = false;
 
 	/* scale up clocks to max frequency before full reinitialization */
-	ufshcd_set_clk_freq(hba, true);
+	ufshcd_scale_clks(hba, true);
 
 	err = ufshcd_hba_enable(hba);