diff mbox series

dt-bindings: bus: qcom,ssc-block-bus: rework arrays and drop redundant minItems

Message ID 20220712154602.26994-1-krzysztof.kozlowski@linaro.org
State Accepted
Commit 2aa0d4c881986b4d0eef35c2651cdc9f3c96d365
Headers show
Series dt-bindings: bus: qcom,ssc-block-bus: rework arrays and drop redundant minItems | expand

Commit Message

Krzysztof Kozlowski July 12, 2022, 3:46 p.m. UTC 
There is no need to specify "minItems" if it equals to "maxItems".  On the
other hand number of items in an array can be specified via describing
items, which might bring some additional information.  This simplifies a
bit the binding.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../bindings/bus/qcom,ssc-block-bus.yaml      | 25 ++++++++-----------
 1 file changed, 11 insertions(+), 14 deletions(-)

Comments

Rob Herring (Arm) July 18, 2022, 8:24 p.m. UTC | #1 
On Tue, 12 Jul 2022 17:46:02 +0200, Krzysztof Kozlowski wrote:
> There is no need to specify "minItems" if it equals to "maxItems".  On the
> other hand number of items in an array can be specified via describing
> items, which might bring some additional information.  This simplifies a
> bit the binding.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../bindings/bus/qcom,ssc-block-bus.yaml      | 25 ++++++++-----------
>  1 file changed, 11 insertions(+), 14 deletions(-)
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml b/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml
index 5b9705079015..8e9e6ff35d7d 100644
--- a/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml
+++ b/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml
@@ -28,11 +28,9 @@  properties:
       - const: qcom,ssc-block-bus
 
   reg:
-    description: |
-      Shall contain the addresses of the SSCAON_CONFIG0 and SSCAON_CONFIG1
-      registers
-    minItems: 2
-    maxItems: 2
+    items:
+      - description: SSCAON_CONFIG0 registers
+      - description: SSCAON_CONFIG1 registers
 
   reg-names:
     items:
@@ -48,7 +46,6 @@  properties:
   ranges: true
 
   clocks:
-    minItems: 6
     maxItems: 6
 
   clock-names:
@@ -61,9 +58,9 @@  properties:
       - const: ssc_ahbs
 
   power-domains:
-    description: Power domain phandles for the ssc_cx and ssc_mx power domains
-    minItems: 2
-    maxItems: 2
+    items:
+      - description: CX power domain
+      - description: MX power domain
 
   power-domain-names:
     items:
@@ -71,11 +68,11 @@  properties:
       - const: ssc_mx
 
   resets:
-    description: |
-      Reset phandles for the ssc_reset and ssc_bcr resets (note: ssc_bcr is the
-      branch control register associated with the ssc_xo and ssc_ahbs clocks)
-    minItems: 2
-    maxItems: 2
+    items:
+      - description: Main reset
+      - description:
+          SSC Branch Control Register reset (associated with the ssc_xo and
+          ssc_ahbs clocks)
 
   reset-names:
     items: