| Message ID | da43e5feeb246c02ba4ce6ffb5fbd35fe7bd9f14.1657876961.git.Perry.Yuan@amd.com |
|---|---|
| State | New |
| Headers | show |
| Series | AMD Pstate Enhancement And Issue Fixs | expand |
On Fri, Jul 15, 2022 at 06:04:32PM +0800, Yuan, Perry wrote: > "acpi_cpc_valid" function already includes the acpi_disabled check and we can > remove the duplicated check here > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > Signed-off-by: Perry Yuan <Perry.Yuan@amd.com> Patch 10, 12, and 13 should be one function update to move the acpi_disabled check into acpi_cpc_valid(), should we squeeze them as one patch? Thanks, Ray > --- > drivers/cpufreq/cppc_cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c > index 24eaf0ec344d..9adb7612993e 100644 > --- a/drivers/cpufreq/cppc_cpufreq.c > +++ b/drivers/cpufreq/cppc_cpufreq.c > @@ -947,7 +947,7 @@ static int __init cppc_cpufreq_init(void) > { > int ret; > > - if ((acpi_disabled) || !acpi_cpc_valid()) > + if (!acpi_cpc_valid()) > return -ENODEV; > > cppc_check_hisi_workaround(); > -- > 2.32.0 >
[AMD Official Use Only - General] Hi Ray. > -----Original Message----- > From: Huang, Ray <Ray.Huang@amd.com> > Sent: Tuesday, July 19, 2022 9:08 AM > To: Yuan, Perry <Perry.Yuan@amd.com> > Cc: rafael.j.wysocki@intel.com; viresh.kumar@linaro.org; Sharma, Deepak > <Deepak.Sharma@amd.com>; Limonciello, Mario > <Mario.Limonciello@amd.com>; Fontenot, Nathan > <Nathan.Fontenot@amd.com>; Deucher, Alexander > <Alexander.Deucher@amd.com>; Su, Jinzhou (Joe) <Jinzhou.Su@amd.com>; > Huang, Shimmer <Shimmer.Huang@amd.com>; Du, Xiaojian > <Xiaojian.Du@amd.com>; Meng, Li (Jassmine) <Li.Meng@amd.com>; linux- > pm@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v4 13/13] cpufreq: CPPC: remove the acpi_disabled check > > On Fri, Jul 15, 2022 at 06:04:32PM +0800, Yuan, Perry wrote: > > "acpi_cpc_valid" function already includes the acpi_disabled check and > > we can remove the duplicated check here > > > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > Signed-off-by: Perry Yuan <Perry.Yuan@amd.com> > > Patch 10, 12, and 13 should be one function update to move the acpi_disabled > check into acpi_cpc_valid(), should we squeeze them as one patch? > > Thanks, > Ray Sure, will merge the changes into one patch in V5. Thanks. Perry. > > > --- > > drivers/cpufreq/cppc_cpufreq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/cpufreq/cppc_cpufreq.c > > b/drivers/cpufreq/cppc_cpufreq.c index 24eaf0ec344d..9adb7612993e > > 100644 > > --- a/drivers/cpufreq/cppc_cpufreq.c > > +++ b/drivers/cpufreq/cppc_cpufreq.c > > @@ -947,7 +947,7 @@ static int __init cppc_cpufreq_init(void) { > > int ret; > > > > - if ((acpi_disabled) || !acpi_cpc_valid()) > > + if (!acpi_cpc_valid()) > > return -ENODEV; > > > > cppc_check_hisi_workaround(); > > -- > > 2.32.0 > >
diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c index 24eaf0ec344d..9adb7612993e 100644 --- a/drivers/cpufreq/cppc_cpufreq.c +++ b/drivers/cpufreq/cppc_cpufreq.c @@ -947,7 +947,7 @@ static int __init cppc_cpufreq_init(void) { int ret; - if ((acpi_disabled) || !acpi_cpc_valid()) + if (!acpi_cpc_valid()) return -ENODEV; cppc_check_hisi_workaround();