[0/2] Execute a linux-generic process mode test

Message ID 20160106144822.GA30249@localhost
State New
Headers show

Commit Message

Stuart Haslam Jan. 6, 2016, 2:48 p.m.
On Wed, Jan 06, 2016 at 02:23:04PM +0000, Stuart Haslam wrote:
> On Tue, Jan 05, 2016 at 10:29:30AM -0500, Mike Holmes wrote:
> > Linux generic supports threads and theoretically processes as the worker and control tasks but process mode is never tested.
> > Add the framework to launch a performance test from the linux-generic implementation with make check in the process configuration.
> > 
> > Mike Holmes (2):
> >   linux-generic: test: move validation tests to their own directory
> >   linux-generic: test: add performance test framework
> > 
> >  platform/linux-generic/m4/configure.m4             |  4 +-
> >  platform/linux-generic/test/Makefile.am            | 53 +++-------------------
> >  .../linux-generic/test/performance/Makefile.am     | 13 ++++++
> >  .../test/performance/odp_scheduling_proc_run       | 25 ++++++++++
> >  .../test/performance/tests-performance.env         |  3 ++
> 
> This file ^^ should not be checked in.
> 
> Other than that the changes look good to me.
> 
> Reviewed-and-Tested-by: Stuart Haslam <stuart.haslam@linaro.org>
> 

Ah wait a sec. That tests-performance.env file was masking a problem
with "make installcheck" because the checked in version had an empty
TESTS list.

The odp_scheduling binary doesn't get installed into the testdir (but
the odp_scheduling_proc_run script does).

This should fix it..

Comments

Mike Holmes Jan. 6, 2016, 2:53 p.m. | #1
On 6 January 2016 at 09:48, Stuart Haslam <stuart.haslam@linaro.org> wrote:

> On Wed, Jan 06, 2016 at 02:23:04PM +0000, Stuart Haslam wrote:

> > On Tue, Jan 05, 2016 at 10:29:30AM -0500, Mike Holmes wrote:

> > > Linux generic supports threads and theoretically processes as the

> worker and control tasks but process mode is never tested.

> > > Add the framework to launch a performance test from the linux-generic

> implementation with make check in the process configuration.

> > >

> > > Mike Holmes (2):

> > >   linux-generic: test: move validation tests to their own directory

> > >   linux-generic: test: add performance test framework

> > >

> > >  platform/linux-generic/m4/configure.m4             |  4 +-

> > >  platform/linux-generic/test/Makefile.am            | 53

> +++-------------------

> > >  .../linux-generic/test/performance/Makefile.am     | 13 ++++++

> > >  .../test/performance/odp_scheduling_proc_run       | 25 ++++++++++

> > >  .../test/performance/tests-performance.env         |  3 ++

> >

> > This file ^^ should not be checked in.

> >

> > Other than that the changes look good to me.

> >

> > Reviewed-and-Tested-by: Stuart Haslam <stuart.haslam@linaro.org>

> >

>

> Ah wait a sec. That tests-performance.env file was masking a problem

> with "make installcheck" because the checked in version had an empty

> TESTS list.

>

> The odp_scheduling binary doesn't get installed into the testdir (but

> the odp_scheduling_proc_run script does).

>

> This should fix it..

>

> diff --git a/test/performance/Makefile.am b/test/performance/Makefile.am

> index 721615b..719be2b 100644

> --- a/test/performance/Makefile.am

> +++ b/test/performance/Makefile.am

> @@ -14,7 +14,7 @@ if test_perf

>  TESTS = $(EXECUTABLES) $(TESTSCRIPTS)

>  endif

>

> -bin_PROGRAMS = $(EXECUTABLES) $(COMPILE_ONLY)

> +test_PROGRAMS = $(EXECUTABLES) $(COMPILE_ONLY)

>

>  odp_atomic_LDFLAGS = $(AM_LDFLAGS) -static

>  odp_atomic_CFLAGS = $(AM_CFLAGS) -I${top_srcdir}/test

>


Thanks, let me incorporate that and send a v2

-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs

Patch

diff --git a/test/performance/Makefile.am b/test/performance/Makefile.am
index 721615b..719be2b 100644
--- a/test/performance/Makefile.am
+++ b/test/performance/Makefile.am
@@ -14,7 +14,7 @@  if test_perf
 TESTS = $(EXECUTABLES) $(TESTSCRIPTS)
 endif
 
-bin_PROGRAMS = $(EXECUTABLES) $(COMPILE_ONLY)
+test_PROGRAMS = $(EXECUTABLES) $(COMPILE_ONLY)
 
 odp_atomic_LDFLAGS = $(AM_LDFLAGS) -static
 odp_atomic_CFLAGS = $(AM_CFLAGS) -I${top_srcdir}/test