From patchwork Wed Jan 6 14:48:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stuart Haslam X-Patchwork-Id: 59245 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp6622252lbb; Wed, 6 Jan 2016 06:48:41 -0800 (PST) X-Received: by 10.140.95.119 with SMTP id h110mr64532346qge.105.1452091720991; Wed, 06 Jan 2016 06:48:40 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id q62si76255757qhq.32.2016.01.06.06.48.40; Wed, 06 Jan 2016 06:48:40 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id E96E261904; Wed, 6 Jan 2016 14:48:39 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=fail reason="verification failed; unprotected key" header.d=linaro.org header.i=@linaro.org header.b=CiVNvBxV; dkim-adsp=none (unprotected policy); dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id F314A616FD; Wed, 6 Jan 2016 14:48:30 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 7A8C5618D9; Wed, 6 Jan 2016 14:48:25 +0000 (UTC) Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by lists.linaro.org (Postfix) with ESMTPS id 2BD69615D4 for ; Wed, 6 Jan 2016 14:48:24 +0000 (UTC) Received: by mail-wm0-f51.google.com with SMTP id f206so62440480wmf.0 for ; Wed, 06 Jan 2016 06:48:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=vceo/SI/E8eN4GUqPUlxFJYyC8ICQD3Pq+Tq853ZWs4=; b=CiVNvBxVzeEHmAHbwrZfy5ZpT877zGY58fLv7HtexBmXRteWINBgMrXSZ34Hd8zVrq xa6S9iLDxTR18TNhO0PqEF7NU5e3G+J1JzS7fX99E483mTz04exEZVFJ3z2EPMyb61u8 dxK3Bm9OGn8y6aICFWwb/SGjfUi3NU5+qJeM4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=vceo/SI/E8eN4GUqPUlxFJYyC8ICQD3Pq+Tq853ZWs4=; b=hZatR634YVkgmjBoiSh8fjkR7kX/ykNdcI690r8hYG059dY7mbxxDWgxmBnk8KTl2H oOafSVbcrxX9V1yBj/rhiwNiZnclu5IntWjYna6jD5juqBvaO+J9vrr2+5T3zC5hPZzc F5QqeTfVxtaSQ8hsmZrK86MnXxIiQoUNP4mAPIzE2/QiKvjLUiXTl6Sw7P2XRFoELkqz 8a1l2u9mmFa292AjaAA4mPTZ3f89YauD27brd+MLRNmw92S1TZzfw/ODFHAd4a1bss/v zaG1z+NOqrKiqIGcQ6/CdXOmlKvXJ9ZSirjRxQVvJlokAPgV6HZg6LCZ+P71KHZwLHkN 3rpw== X-Gm-Message-State: ALoCoQlCfL5F9pRPLgp45wGTaCOqv4EeR/R1SlJgNQZWsPidWu7WSfkcuob72XuKx5oiecuW3af1gsoNsMpHd/gqYEf4+XoOgA== X-Received: by 10.28.65.193 with SMTP id o184mr10208150wma.15.1452091703255; Wed, 06 Jan 2016 06:48:23 -0800 (PST) Received: from localhost ([2001:41d0:a:3cb4::abcd]) by smtp.gmail.com with ESMTPSA id l7sm96583955wjx.14.2016.01.06.06.48.22 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 06 Jan 2016 06:48:22 -0800 (PST) Date: Wed, 6 Jan 2016 14:48:22 +0000 From: Stuart Haslam To: Mike Holmes Message-ID: <20160106144822.GA30249@localhost> References: <1452007772-11744-1-git-send-email-mike.holmes@linaro.org> <20160106142304.GB932@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160106142304.GB932@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) X-Topics: patch Cc: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 0/2] Execute a linux-generic process mode test X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" On Wed, Jan 06, 2016 at 02:23:04PM +0000, Stuart Haslam wrote: > On Tue, Jan 05, 2016 at 10:29:30AM -0500, Mike Holmes wrote: > > Linux generic supports threads and theoretically processes as the worker and control tasks but process mode is never tested. > > Add the framework to launch a performance test from the linux-generic implementation with make check in the process configuration. > > > > Mike Holmes (2): > > linux-generic: test: move validation tests to their own directory > > linux-generic: test: add performance test framework > > > > platform/linux-generic/m4/configure.m4 | 4 +- > > platform/linux-generic/test/Makefile.am | 53 +++------------------- > > .../linux-generic/test/performance/Makefile.am | 13 ++++++ > > .../test/performance/odp_scheduling_proc_run | 25 ++++++++++ > > .../test/performance/tests-performance.env | 3 ++ > > This file ^^ should not be checked in. > > Other than that the changes look good to me. > > Reviewed-and-Tested-by: Stuart Haslam > Ah wait a sec. That tests-performance.env file was masking a problem with "make installcheck" because the checked in version had an empty TESTS list. The odp_scheduling binary doesn't get installed into the testdir (but the odp_scheduling_proc_run script does). This should fix it.. diff --git a/test/performance/Makefile.am b/test/performance/Makefile.am index 721615b..719be2b 100644 --- a/test/performance/Makefile.am +++ b/test/performance/Makefile.am @@ -14,7 +14,7 @@ if test_perf TESTS = $(EXECUTABLES) $(TESTSCRIPTS) endif -bin_PROGRAMS = $(EXECUTABLES) $(COMPILE_ONLY) +test_PROGRAMS = $(EXECUTABLES) $(COMPILE_ONLY) odp_atomic_LDFLAGS = $(AM_LDFLAGS) -static odp_atomic_CFLAGS = $(AM_CFLAGS) -I${top_srcdir}/test