| Message ID | d6cdd8ce642be2a2737d6c1ac16653f2e79831d8.1659764274.git.christophe.jaillet@wanadoo.fr |
|---|---|
| State | Superseded |
| Headers | show |
| Series | leds: pwm-multicolor: Simplify some error message | expand |
diff --git a/drivers/leds/rgb/leds-pwm-multicolor.c b/drivers/leds/rgb/leds-pwm-multicolor.c index da9d2218ae18..454afa00735c 100644 --- a/drivers/leds/rgb/leds-pwm-multicolor.c +++ b/drivers/leds/rgb/leds-pwm-multicolor.c @@ -158,8 +158,8 @@ static int led_pwm_mc_probe(struct platform_device *pdev) ret = led_pwm_mc_set(cdev, cdev->brightness); if (ret) return dev_err_probe(&pdev->dev, ret, - "failed to set led PWM value for %s: %d", - cdev->name, ret); + "failed to set led PWM value for %s", + cdev->name); platform_set_drvdata(pdev, priv); return 0;
dev_err_probe() already prints the error code in a human readable way, so there is no need to duplicate it as a numerical value at the end of the message. Fixes: 9fa2762110dd ("usb: common: usb-conn-gpio: use dev_err_probe() to print log") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- This is also likely that there should be "goto release_mcnode;" instead of a direct return. I've not been able to fully track it down, so I leave it as-is. --- drivers/leds/rgb/leds-pwm-multicolor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)