| Message ID | 1452706712-28112-1-git-send-email-ivan.khoronzhuk@linaro.org |
|---|---|
| State | Accepted |
| Commit | 03f65432ac4242400c52cac49f9a8750356cc6a5 |
| Headers | show |
ping On 13.01.16 19:38, Ivan Khoronzhuk wrote: > The odp_pktio_stop() called is supposed to return error. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > --- > test/validation/pktio/pktio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c > index 29ad4ea..1ca4979 100644 > --- a/test/validation/pktio/pktio.c > +++ b/test/validation/pktio/pktio.c > @@ -737,7 +737,7 @@ void pktio_test_start_stop(void) > /* Interfaces are stopped by default, > * Check that stop when stopped generates an error */ > ret = odp_pktio_stop(pktio[0]); > - CU_ASSERT(ret <= 0); > + CU_ASSERT(ret < 0); > > /* start first */ > ret = odp_pktio_start(pktio[0]); >
ping On 13.01.16 19:38, Ivan Khoronzhuk wrote: > The odp_pktio_stop() called is supposed to return error. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > --- > test/validation/pktio/pktio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c > index 29ad4ea..1ca4979 100644 > --- a/test/validation/pktio/pktio.c > +++ b/test/validation/pktio/pktio.c > @@ -737,7 +737,7 @@ void pktio_test_start_stop(void) > /* Interfaces are stopped by default, > * Check that stop when stopped generates an error */ > ret = odp_pktio_stop(pktio[0]); > - CU_ASSERT(ret <= 0); > + CU_ASSERT(ret < 0); > > /* start first */ > ret = odp_pktio_start(pktio[0]); >
On Wed, Jan 13, 2016 at 11:38 AM, Ivan Khoronzhuk < ivan.khoronzhuk@linaro.org> wrote: > The odp_pktio_stop() called is supposed to return error. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > test/validation/pktio/pktio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c > index 29ad4ea..1ca4979 100644 > --- a/test/validation/pktio/pktio.c > +++ b/test/validation/pktio/pktio.c > @@ -737,7 +737,7 @@ void pktio_test_start_stop(void) > /* Interfaces are stopped by default, > * Check that stop when stopped generates an error */ > ret = odp_pktio_stop(pktio[0]); > - CU_ASSERT(ret <= 0); > + CU_ASSERT(ret < 0); > > /* start first */ > ret = odp_pktio_start(pktio[0]); > -- > 1.9.1 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
Merged, Maxim. On 01/21/2016 00:32, Bill Fischofer wrote: > > > On Wed, Jan 13, 2016 at 11:38 AM, Ivan Khoronzhuk > <ivan.khoronzhuk@linaro.org <mailto:ivan.khoronzhuk@linaro.org>> wrote: > > The odp_pktio_stop() called is supposed to return error. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org > <mailto:ivan.khoronzhuk@linaro.org>> > > > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org > <mailto:bill.fischofer@linaro.org>> > > --- > test/validation/pktio/pktio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/validation/pktio/pktio.c > b/test/validation/pktio/pktio.c > index 29ad4ea..1ca4979 100644 > --- a/test/validation/pktio/pktio.c > +++ b/test/validation/pktio/pktio.c > @@ -737,7 +737,7 @@ void pktio_test_start_stop(void) > /* Interfaces are stopped by default, > * Check that stop when stopped generates an error */ > ret = odp_pktio_stop(pktio[0]); > - CU_ASSERT(ret <= 0); > + CU_ASSERT(ret < 0); > > /* start first */ > ret = odp_pktio_start(pktio[0]); > -- > 1.9.1 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index 29ad4ea..1ca4979 100644 --- a/test/validation/pktio/pktio.c +++ b/test/validation/pktio/pktio.c @@ -737,7 +737,7 @@ void pktio_test_start_stop(void) /* Interfaces are stopped by default, * Check that stop when stopped generates an error */ ret = odp_pktio_stop(pktio[0]); - CU_ASSERT(ret <= 0); + CU_ASSERT(ret < 0); /* start first */ ret = odp_pktio_start(pktio[0]);
The odp_pktio_stop() called is supposed to return error. Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> --- test/validation/pktio/pktio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)