| Message ID | 20220819032615.884847-16-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | linux-user: Fix siginfo_t contents when jumping to non-readable pages | expand |
On Fri, Aug 19, 2022 at 1:36 PM Richard Henderson <richard.henderson@linaro.org> wrote: > > The only user can easily use translator_lduw and > adjust the type to signed during the return. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > include/exec/translator.h | 1 - > target/i386/tcg/translate.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/exec/translator.h b/include/exec/translator.h > index 0d0bf3a31e..45b9268ca4 100644 > --- a/include/exec/translator.h > +++ b/include/exec/translator.h > @@ -178,7 +178,6 @@ bool translator_use_goto_tb(DisasContextBase *db, target_ulong dest); > > #define FOR_EACH_TRANSLATOR_LD(F) \ > F(translator_ldub, uint8_t, cpu_ldub_code, /* no swap */) \ > - F(translator_ldsw, int16_t, cpu_ldsw_code, bswap16) \ > F(translator_lduw, uint16_t, cpu_lduw_code, bswap16) \ > F(translator_ldl, uint32_t, cpu_ldl_code, bswap32) \ > F(translator_ldq, uint64_t, cpu_ldq_code, bswap64) > diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c > index b7972f0ff5..a23417d058 100644 > --- a/target/i386/tcg/translate.c > +++ b/target/i386/tcg/translate.c > @@ -2033,7 +2033,7 @@ static inline uint8_t x86_ldub_code(CPUX86State *env, DisasContext *s) > > static inline int16_t x86_ldsw_code(CPUX86State *env, DisasContext *s) > { > - return translator_ldsw(env, &s->base, advance_pc(env, s, 2)); > + return translator_lduw(env, &s->base, advance_pc(env, s, 2)); > } > > static inline uint16_t x86_lduw_code(CPUX86State *env, DisasContext *s) > -- > 2.34.1 > >
diff --git a/include/exec/translator.h b/include/exec/translator.h index 0d0bf3a31e..45b9268ca4 100644 --- a/include/exec/translator.h +++ b/include/exec/translator.h @@ -178,7 +178,6 @@ bool translator_use_goto_tb(DisasContextBase *db, target_ulong dest); #define FOR_EACH_TRANSLATOR_LD(F) \ F(translator_ldub, uint8_t, cpu_ldub_code, /* no swap */) \ - F(translator_ldsw, int16_t, cpu_ldsw_code, bswap16) \ F(translator_lduw, uint16_t, cpu_lduw_code, bswap16) \ F(translator_ldl, uint32_t, cpu_ldl_code, bswap32) \ F(translator_ldq, uint64_t, cpu_ldq_code, bswap64) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index b7972f0ff5..a23417d058 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -2033,7 +2033,7 @@ static inline uint8_t x86_ldub_code(CPUX86State *env, DisasContext *s) static inline int16_t x86_ldsw_code(CPUX86State *env, DisasContext *s) { - return translator_ldsw(env, &s->base, advance_pc(env, s, 2)); + return translator_lduw(env, &s->base, advance_pc(env, s, 2)); } static inline uint16_t x86_lduw_code(CPUX86State *env, DisasContext *s)
The only user can easily use translator_lduw and adjust the type to signed during the return. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- include/exec/translator.h | 1 - target/i386/tcg/translate.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)