[8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock

Message ID 1452885673-30891-9-git-send-email-anders.roxell@linaro.org
State New
Headers show

Commit Message

Anders Roxell Jan. 15, 2016, 7:21 p.m.
Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
warning without this fix:
../drivers/cpuidle/coupled.c:122:21: warning: 'cpuidle_coupled_lock'
defined but not used [-Wunused-variable]

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

---
 drivers/cpuidle/coupled.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Anders Roxell Jan. 20, 2016, 9:28 p.m. | #1
On 18 January 2016 at 18:02, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> * Anders Roxell | 2016-01-15 20:21:12 [+0100]:

>

>>Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation

>>warning without this fix:

>>../drivers/cpuidle/coupled.c:122:21: warning: 'cpuidle_coupled_lock'

>>defined but not used [-Wunused-variable]

>>

>>Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

>

> Could you please forward this patch upstream? The driver was introduced

> in 4126c0197bc8 ("cpuidle: add support for states that affect multiple

> cpus") with the cpuidle_coupled_lock variable unused. This is not -RT

> specific.


Yes, I'll do that.

Cheers,
Anders

>

>>---

>> drivers/cpuidle/coupled.c | 1 -

>> 1 file changed, 1 deletion(-)

>>

>>diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c

>>index 344058f..d5657d5 100644

>>--- a/drivers/cpuidle/coupled.c

>>+++ b/drivers/cpuidle/coupled.c

>>@@ -119,7 +119,6 @@ struct cpuidle_coupled {

>>

>> #define CPUIDLE_COUPLED_NOT_IDLE      (-1)

>>

>>-static DEFINE_MUTEX(cpuidle_coupled_lock);

>> static DEFINE_PER_CPU(struct call_single_data, cpuidle_coupled_poke_cb);

>>

>> /*

>

> Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch hide | download patch | download mbox

diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
index 344058f..d5657d5 100644
--- a/drivers/cpuidle/coupled.c
+++ b/drivers/cpuidle/coupled.c
@@ -119,7 +119,6 @@  struct cpuidle_coupled {
 
 #define CPUIDLE_COUPLED_NOT_IDLE	(-1)
 
-static DEFINE_MUTEX(cpuidle_coupled_lock);
 static DEFINE_PER_CPU(struct call_single_data, cpuidle_coupled_poke_cb);
 
 /*