diff mbox series

[4/5] ASoC: fsl: fsl-utils: remove useless assignment

Message ID 20220822184239.169757-5-pierre-louis.bossart@linux.intel.com
State Accepted
Commit 3653a6a2a7c146f04940d572d2728c939b50cba1
Headers show
Series ASoC: codecs: minor cppcheck cleanups | expand

Commit Message

Pierre-Louis Bossart Aug. 22, 2022, 6:42 p.m. UTC
cppcheck warning:

sound/soc/fsl/fsl_utils.c:127:10: style: Variable 'ret' is assigned a
value that is never used. [unreadVariable]
 int ret = 0;
         ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Chao Song <chao.song@intel.com>
---
 sound/soc/fsl/fsl_utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shengjiu Wang Aug. 23, 2022, 1:55 a.m. UTC | #1
On Tue, Aug 23, 2022 at 2:43 AM Pierre-Louis Bossart <
pierre-louis.bossart@linux.intel.com> wrote:

> cppcheck warning:
>
> sound/soc/fsl/fsl_utils.c:127:10: style: Variable 'ret' is assigned a
> value that is never used. [unreadVariable]
>  int ret = 0;
>          ^
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> Reviewed-by: Chao Song <chao.song@intel.com>
>

Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>

Best regards
Wang Shengjiu

> ---
>  sound/soc/fsl/fsl_utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_utils.c b/sound/soc/fsl/fsl_utils.c
> index d0fc430f7033d..a5ab27c2f711c 100644
> --- a/sound/soc/fsl/fsl_utils.c
> +++ b/sound/soc/fsl/fsl_utils.c
> @@ -124,7 +124,7 @@ void fsl_asoc_reparent_pll_clocks(struct device *dev,
> struct clk *clk,
>  {
>         struct clk *p, *pll = NULL, *npll = NULL;
>         bool reparent = false;
> -       int ret = 0;
> +       int ret;
>
>         if (!clk || !pll8k_clk || !pll11k_clk)
>                 return;
> --
> 2.34.1
>
>
diff mbox series

Patch

diff --git a/sound/soc/fsl/fsl_utils.c b/sound/soc/fsl/fsl_utils.c
index d0fc430f7033d..a5ab27c2f711c 100644
--- a/sound/soc/fsl/fsl_utils.c
+++ b/sound/soc/fsl/fsl_utils.c
@@ -124,7 +124,7 @@  void fsl_asoc_reparent_pll_clocks(struct device *dev, struct clk *clk,
 {
 	struct clk *p, *pll = NULL, *npll = NULL;
 	bool reparent = false;
-	int ret = 0;
+	int ret;
 
 	if (!clk || !pll8k_clk || !pll11k_clk)
 		return;