| Message ID | 20220830152428.12625-1-jerry.ray@microchip.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v5,1/2] dts: arm: Adding documentation for SAMA5D3-EDS board | expand |
On 30/08/2022 18:24, Jerry Ray wrote: > Adding the SAMA5D3-EDS board from Microchip into the atmel AT91 board > description yaml file. > > Signed-off-by: Jerry Ray <jerry.ray@microchip.com> > Acked-by: Rob Herring <robh@kernel.org> > --- Use subject prefixes matching the subsystem (git log --oneline -- ...). > v4->v5: > - No change > v3->v4: > - No change > v2->v3: > - No change > v1->v2: > - Added Device Tree documentation for Microchip SAMA5D3-EDS board > --- > Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > index 08efb259a947..635491aaeb0c 100644 > --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > @@ -138,6 +138,13 @@ properties: > - const: atmel,at91sam9g20 > - const: atmel,at91sam9 > > + - description: Microchip SAMA5D3 Ethernet Development System Board > + items: > + - const: microchip,sama5d3-eds > + - const: atmel,sama5d36 This does not match your DTS. Test your bindings... Please drop Rob's ack as this is not correct. Best regards, Krzysztof
On 30/08/2022 23:16, Jerry.Ray@microchip.com wrote: >> >>> + >>> + chosen { >>> + stdout-path = "serial0:115200n8"; >>> + }; >>> + >>> + clocks { >>> + slow_xtal { >> >> No underscores in node names. Generic node names, so at least add some generic prefix or suffix, e.g.: "slow-xtal-clock" >> > > I'm not at liberty to change these names. Pre-existing drivers are counting on them. > The hardware leverages the SAMA5D3-xplained board. > I'm leveraging the at91-sama5d3_xplained.dts. > The board will not boot up if I modify the names. For custom names you have clock-output-names... But anyway it seems you override existing nodes, so this should be override by label, not by entire path. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml index 08efb259a947..635491aaeb0c 100644 --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml @@ -138,6 +138,13 @@ properties: - const: atmel,at91sam9g20 - const: atmel,at91sam9 + - description: Microchip SAMA5D3 Ethernet Development System Board + items: + - const: microchip,sama5d3-eds + - const: atmel,sama5d36 + - const: atmel,sama5d3 + - const: atmel,sama5 + - items: - enum: - atmel,sama5d31