| Message ID | 1453458267-16403-1-git-send-email-ivan.khoronzhuk@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
sent patch with corrected tag On 22.01.16 12:24, Ivan Khoronzhuk wrote: > The scheduler test should test scheduler, not resource limits. > For instance, prio_num * QUEUES_PER_PRIO * 4. In case if prio_num = 16, > it's easily exits the queues maximum number allowed, > 16 * 16 * 4 = 1024, plus queues created for other purposes, it can be > close to ODP_CONFIG_QUEUES. The same for allocated bufs num, that is > prio_num * QUEUES_PER_PRIO * TEST_NUM_BUFS. It's h/w dependent, and should > be in normal frames. This patch tunes resource usage in order to allow > test passing for different h/w. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > --- > test/validation/scheduler/scheduler.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/test/validation/scheduler/scheduler.c b/test/validation/scheduler/scheduler.c > index ea246d4..100a627 100644 > --- a/test/validation/scheduler/scheduler.c > +++ b/test/validation/scheduler/scheduler.c > @@ -9,12 +9,12 @@ > #include "scheduler.h" > > #define MAX_WORKERS_THREADS 32 > -#define MSG_POOL_SIZE (4 * 1024 * 1024) > -#define QUEUES_PER_PRIO 16 > +#define MSG_POOL_SIZE (400 * 1024) > +#define QUEUES_PER_PRIO 8 > #define BUF_SIZE 64 > -#define TEST_NUM_BUFS 100 > +#define TEST_NUM_BUFS 48 > #define BURST_BUF_SIZE 4 > -#define NUM_BUFS_EXCL 10000 > +#define NUM_BUFS_EXCL 48 > #define NUM_BUFS_PAUSE 1000 > #define NUM_BUFS_BEFORE_PAUSE 10 > >
It's not clear from the patch exactly what the problem is that it is designed to address. If the issue is that the test exceeds config values for certain types of HW then a better approach would be for the test to use the odp_config_xxx() APIs to get the values needed for the particular platform it's running on. On Fri, Jan 22, 2016 at 10:35 AM, Ivan Khoronzhuk < ivan.khoronzhuk@linaro.org> wrote: > sent patch with corrected tag > > > On 22.01.16 12:24, Ivan Khoronzhuk wrote: > >> The scheduler test should test scheduler, not resource limits. >> For instance, prio_num * QUEUES_PER_PRIO * 4. In case if prio_num = 16, >> it's easily exits the queues maximum number allowed, >> 16 * 16 * 4 = 1024, plus queues created for other purposes, it can be >> close to ODP_CONFIG_QUEUES. The same for allocated bufs num, that is >> prio_num * QUEUES_PER_PRIO * TEST_NUM_BUFS. It's h/w dependent, and should >> be in normal frames. This patch tunes resource usage in order to allow >> test passing for different h/w. >> >> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> >> --- >> test/validation/scheduler/scheduler.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/test/validation/scheduler/scheduler.c >> b/test/validation/scheduler/scheduler.c >> index ea246d4..100a627 100644 >> --- a/test/validation/scheduler/scheduler.c >> +++ b/test/validation/scheduler/scheduler.c >> @@ -9,12 +9,12 @@ >> #include "scheduler.h" >> >> #define MAX_WORKERS_THREADS 32 >> -#define MSG_POOL_SIZE (4 * 1024 * 1024) >> -#define QUEUES_PER_PRIO 16 >> +#define MSG_POOL_SIZE (400 * 1024) >> +#define QUEUES_PER_PRIO 8 >> #define BUF_SIZE 64 >> -#define TEST_NUM_BUFS 100 >> +#define TEST_NUM_BUFS 48 >> #define BURST_BUF_SIZE 4 >> -#define NUM_BUFS_EXCL 10000 >> +#define NUM_BUFS_EXCL 48 >> #define NUM_BUFS_PAUSE 1000 >> #define NUM_BUFS_BEFORE_PAUSE 10 >> >> >> > -- > Regards, > Ivan Khoronzhuk > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
diff --git a/test/validation/scheduler/scheduler.c b/test/validation/scheduler/scheduler.c index ea246d4..100a627 100644 --- a/test/validation/scheduler/scheduler.c +++ b/test/validation/scheduler/scheduler.c @@ -9,12 +9,12 @@ #include "scheduler.h" #define MAX_WORKERS_THREADS 32 -#define MSG_POOL_SIZE (4 * 1024 * 1024) -#define QUEUES_PER_PRIO 16 +#define MSG_POOL_SIZE (400 * 1024) +#define QUEUES_PER_PRIO 8 #define BUF_SIZE 64 -#define TEST_NUM_BUFS 100 +#define TEST_NUM_BUFS 48 #define BURST_BUF_SIZE 4 -#define NUM_BUFS_EXCL 10000 +#define NUM_BUFS_EXCL 48 #define NUM_BUFS_PAUSE 1000 #define NUM_BUFS_BEFORE_PAUSE 10
The scheduler test should test scheduler, not resource limits. For instance, prio_num * QUEUES_PER_PRIO * 4. In case if prio_num = 16, it's easily exits the queues maximum number allowed, 16 * 16 * 4 = 1024, plus queues created for other purposes, it can be close to ODP_CONFIG_QUEUES. The same for allocated bufs num, that is prio_num * QUEUES_PER_PRIO * TEST_NUM_BUFS. It's h/w dependent, and should be in normal frames. This patch tunes resource usage in order to allow test passing for different h/w. Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> --- test/validation/scheduler/scheduler.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)