[2/2] ARM: versatile: move restart to the device tree

Message ID 1453710656-14280-1-git-send-email-linus.walleij@linaro.org
State New
Headers show

Commit Message

Linus Walleij Jan. 25, 2016, 8:30 a.m.
We have a power/reset driver for the Versatile family
in drivers/power/reset so let's just activate that driver
and use it and get rid of some non-DT remnants.

Cc: Sebastian Reichel <sre@kernel.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 arch/arm/mach-versatile/Kconfig        |  3 +++
 arch/arm/mach-versatile/versatile_dt.c | 13 -------------
 2 files changed, 3 insertions(+), 13 deletions(-)

-- 
2.4.3


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Comments

Arnd Bergmann Jan. 25, 2016, 8:53 a.m. | #1
On Monday 25 January 2016 09:30:56 Linus Walleij wrote:
> We have a power/reset driver for the Versatile family

> in drivers/power/reset so let's just activate that driver

> and use it and get rid of some non-DT remnants.

> 

> Cc: Sebastian Reichel <sre@kernel.org>

> Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

> Cc: David Woodhouse <dwmw2@infradead.org>

> Cc: Rob Herring <robh@kernel.org>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> 


Good idea.

Acked-by: Arnd Bergmann <arnd@arndb.de>


I don't see patch 1/2 here. Maybe that was caught by the list
spam filters in some way?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Sebastian Reichel Feb. 15, 2016, 5:01 a.m. | #2
Hi,

On Mon, Jan 25, 2016 at 09:30:56AM +0100, Linus Walleij wrote:
> We have a power/reset driver for the Versatile family

> in drivers/power/reset so let's just activate that driver

> and use it and get rid of some non-DT remnants.

> 

> Cc: Sebastian Reichel <sre@kernel.org>

> Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

> Cc: David Woodhouse <dwmw2@infradead.org>

> Cc: Rob Herring <robh@kernel.org>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>


Acked-By: Sebastian Reichel <sre@kernel.org>


-- Sebastian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Patch

diff --git a/arch/arm/mach-versatile/Kconfig b/arch/arm/mach-versatile/Kconfig
index e40f777ccf7d..b0cc26284fc9 100644
--- a/arch/arm/mach-versatile/Kconfig
+++ b/arch/arm/mach-versatile/Kconfig
@@ -8,8 +8,11 @@  config ARCH_VERSATILE
 	select COMMON_CLK_VERSATILE
 	select CPU_ARM926T
 	select ICST
+	select MFD_SYSCON
 	select MIGHT_HAVE_PCI
 	select PLAT_VERSATILE
+	select POWER_RESET
+	select POWER_RESET_VERSATILE
 	select VERSATILE_FPGA_IRQ
 	help
 	  This enables support for ARM Ltd Versatile board.
diff --git a/arch/arm/mach-versatile/versatile_dt.c b/arch/arm/mach-versatile/versatile_dt.c
index c44871851255..cf8a4ea6311a 100644
--- a/arch/arm/mach-versatile/versatile_dt.c
+++ b/arch/arm/mach-versatile/versatile_dt.c
@@ -345,18 +345,6 @@  static void __init versatile_init_early(void)
 	       __io_address(VERSATILE_SCTL_BASE));
 }
 
-static void versatile_restart(enum reboot_mode mode, const char *cmd)
-{
-	u32 val;
-
-	val = readl(versatile_sys_base + VERSATILE_SYS_RESETCTL_OFFSET);
-	val |= 0x105;
-
-	writel(0xa05f, versatile_sys_base + VERSATILE_SYS_LOCK_OFFSET);
-	writel(val, versatile_sys_base + VERSATILE_SYS_RESETCTL_OFFSET);
-	writel(0, versatile_sys_base + VERSATILE_SYS_LOCK_OFFSET);
-}
-
 static void __init versatile_dt_pci_init(void)
 {
 	u32 val;
@@ -420,5 +408,4 @@  DT_MACHINE_START(VERSATILE_PB, "ARM-Versatile (Device Tree Support)")
 	.init_early	= versatile_init_early,
 	.init_machine	= versatile_dt_init,
 	.dt_compat	= versatile_dt_match,
-	.restart	= versatile_restart,
 MACHINE_END