| Message ID | 20220913150420.kernel.v1.1.I54824fdfb8de716a1d7d9eccecbbfb6e45b116a8@changeid |
|---|---|
| State | New |
| Headers | show |
| Series | Bluetooth: hci_sync: allow advertising during active scan without privacy | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=676705 ---Test result--- Test Summary: CheckPatch PASS 0.94 seconds GitLint FAIL 0.47 seconds SubjectPrefix PASS 0.31 seconds BuildKernel PASS 40.55 seconds BuildKernel32 PASS 35.44 seconds Incremental Build with patchesPASS 52.30 seconds TestRunner: Setup PASS 604.47 seconds TestRunner: l2cap-tester PASS 19.00 seconds TestRunner: iso-tester PASS 18.39 seconds TestRunner: bnep-tester PASS 7.23 seconds TestRunner: mgmt-tester PASS 115.07 seconds TestRunner: rfcomm-tester PASS 11.59 seconds TestRunner: sco-tester PASS 10.92 seconds TestRunner: smp-tester PASS 10.75 seconds TestRunner: userchan-tester PASS 7.73 seconds Details ############################## Test: GitLint - FAIL - 0.47 seconds Run gitlint with rule in .gitlint [kernel,v1,1/1] Bluetooth: hci_sync: allow advertising during active scan without privacy 1: T1 Title exceeds max length (89>80): "[kernel,v1,1/1] Bluetooth: hci_sync: allow advertising during active scan without privacy" --- Regards, Linux Bluetooth
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c index 41b6d19c70b06..422f7c6911d9f 100644 --- a/net/bluetooth/hci_sync.c +++ b/net/bluetooth/hci_sync.c @@ -5351,7 +5351,7 @@ static int hci_active_scan_sync(struct hci_dev *hdev, uint16_t interval) /* Pause advertising since active scanning disables address resolution * which advertising depend on in order to generate its RPAs. */ - if (use_ll_privacy(hdev)) { + if (use_ll_privacy(hdev) && hci_dev_test_flag(hdev, HCI_PRIVACY)) { err = hci_pause_advertising_sync(hdev); if (err) { bt_dev_err(hdev, "pause advertising failed: %d", err);
Address resolution will be paused during active scan to allow any advertising reports reach the host. If LL privacy is enabled, advertising will rely on the controller to generate new RPA. If host is not using RPA, there is no need to stop advertising during active scan because there is no need to generate RPA in the controller. Signed-off-by: Zhengping Jiang <jiangzp@google.com> --- Changes in v1: - Check privacy flag when disable advertising net/bluetooth/hci_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)