diff mbox

[1/3] linux-generic: remove direct include of stdint.h by atomic.h

Message ID 1453928008-4150-1-git-send-email-mike.holmes@linaro.org
State Accepted
Commit 0346b58da91fbf9de80b27420bf17130b1f6d74e
Headers show

Commit Message

Mike Holmes Jan. 27, 2016, 8:53 p.m. UTC
atomic.h should include odp/std_types.h in line with the precedent
set by the other headers.

Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
 platform/linux-generic/include/odp/atomic.h            | 1 -
 platform/linux-generic/include/odp/barrier.h           | 1 +
 platform/linux-generic/include/odp/plat/atomic_types.h | 1 +
 platform/linux-generic/include/odp/std_types.h         | 1 +
 4 files changed, 3 insertions(+), 1 deletion(-)

Comments

Bill Fischofer Jan. 28, 2016, 1:52 a.m. UTC | #1
For this series:

Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org>

On Wed, Jan 27, 2016 at 2:53 PM, Mike Holmes <mike.holmes@linaro.org> wrote:

> atomic.h should include odp/std_types.h in line with the precedent

> set by the other headers.

>

> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>

> ---

>  platform/linux-generic/include/odp/atomic.h            | 1 -

>  platform/linux-generic/include/odp/barrier.h           | 1 +

>  platform/linux-generic/include/odp/plat/atomic_types.h | 1 +

>  platform/linux-generic/include/odp/std_types.h         | 1 +

>  4 files changed, 3 insertions(+), 1 deletion(-)

>

> diff --git a/platform/linux-generic/include/odp/atomic.h

> b/platform/linux-generic/include/odp/atomic.h

> index deb4039..10cf361 100644

> --- a/platform/linux-generic/include/odp/atomic.h

> +++ b/platform/linux-generic/include/odp/atomic.h

> @@ -17,7 +17,6 @@

>  extern "C" {

>  #endif

>

> -#include <stdint.h>

>  #include <odp/align.h>

>  #include <odp/plat/atomic_types.h>

>

> diff --git a/platform/linux-generic/include/odp/barrier.h

> b/platform/linux-generic/include/odp/barrier.h

> index 42df859..3447429 100644

> --- a/platform/linux-generic/include/odp/barrier.h

> +++ b/platform/linux-generic/include/odp/barrier.h

> @@ -17,6 +17,7 @@

>  extern "C" {

>  #endif

>

> +#include <odp/std_types.h>

>  #include <odp/atomic.h>

>  #include <odp/plat/shared_memory_types.h>

>  #include <odp/plat/barrier_types.h>

> diff --git a/platform/linux-generic/include/odp/plat/atomic_types.h

> b/platform/linux-generic/include/odp/plat/atomic_types.h

> index 0f6c353..0fe15ed 100644

> --- a/platform/linux-generic/include/odp/plat/atomic_types.h

> +++ b/platform/linux-generic/include/odp/plat/atomic_types.h

> @@ -18,6 +18,7 @@

>  extern "C" {

>  #endif

>

> +#include <odp/std_types.h>

>  #include <odp/align.h>

>

>  /**

> diff --git a/platform/linux-generic/include/odp/std_types.h

> b/platform/linux-generic/include/odp/std_types.h

> index 1bd22ff..f509243 100644

> --- a/platform/linux-generic/include/odp/std_types.h

> +++ b/platform/linux-generic/include/odp/std_types.h

> @@ -17,6 +17,7 @@

>  extern "C" {

>  #endif

>

> +#include <stdint.h>

>  #include <stddef.h>

>  #include <stdbool.h>

>  #include <stdint.h>

> --

> 2.5.0

>

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp

>
Maxim Uvarov Jan. 28, 2016, 12:12 p.m. UTC | #2
Merged,
Maxim.

On 01/28/2016 04:52, Bill Fischofer wrote:
> For this series:
>
> Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org 
> <mailto:bill.fischofer@linaro.org>>
>
> On Wed, Jan 27, 2016 at 2:53 PM, Mike Holmes <mike.holmes@linaro.org 
> <mailto:mike.holmes@linaro.org>> wrote:
>
>     atomic.h should include odp/std_types.h in line with the precedent
>     set by the other headers.
>
>     Signed-off-by: Mike Holmes <mike.holmes@linaro.org
>     <mailto:mike.holmes@linaro.org>>
>     ---
>      platform/linux-generic/include/odp/atomic.h            | 1 -
>      platform/linux-generic/include/odp/barrier.h           | 1 +
>      platform/linux-generic/include/odp/plat/atomic_types.h | 1 +
>      platform/linux-generic/include/odp/std_types.h         | 1 +
>      4 files changed, 3 insertions(+), 1 deletion(-)
>
>     diff --git a/platform/linux-generic/include/odp/atomic.h
>     b/platform/linux-generic/include/odp/atomic.h
>     index deb4039..10cf361 100644
>     --- a/platform/linux-generic/include/odp/atomic.h
>     +++ b/platform/linux-generic/include/odp/atomic.h
>     @@ -17,7 +17,6 @@
>      extern "C" {
>      #endif
>
>     -#include <stdint.h>
>      #include <odp/align.h>
>      #include <odp/plat/atomic_types.h>
>
>     diff --git a/platform/linux-generic/include/odp/barrier.h
>     b/platform/linux-generic/include/odp/barrier.h
>     index 42df859..3447429 100644
>     --- a/platform/linux-generic/include/odp/barrier.h
>     +++ b/platform/linux-generic/include/odp/barrier.h
>     @@ -17,6 +17,7 @@
>      extern "C" {
>      #endif
>
>     +#include <odp/std_types.h>
>      #include <odp/atomic.h>
>      #include <odp/plat/shared_memory_types.h>
>      #include <odp/plat/barrier_types.h>
>     diff --git
>     a/platform/linux-generic/include/odp/plat/atomic_types.h
>     b/platform/linux-generic/include/odp/plat/atomic_types.h
>     index 0f6c353..0fe15ed 100644
>     --- a/platform/linux-generic/include/odp/plat/atomic_types.h
>     +++ b/platform/linux-generic/include/odp/plat/atomic_types.h
>     @@ -18,6 +18,7 @@
>      extern "C" {
>      #endif
>
>     +#include <odp/std_types.h>
>      #include <odp/align.h>
>
>      /**
>     diff --git a/platform/linux-generic/include/odp/std_types.h
>     b/platform/linux-generic/include/odp/std_types.h
>     index 1bd22ff..f509243 100644
>     --- a/platform/linux-generic/include/odp/std_types.h
>     +++ b/platform/linux-generic/include/odp/std_types.h
>     @@ -17,6 +17,7 @@
>      extern "C" {
>      #endif
>
>     +#include <stdint.h>
>      #include <stddef.h>
>      #include <stdbool.h>
>      #include <stdint.h>
>     --
>     2.5.0
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/platform/linux-generic/include/odp/atomic.h b/platform/linux-generic/include/odp/atomic.h
index deb4039..10cf361 100644
--- a/platform/linux-generic/include/odp/atomic.h
+++ b/platform/linux-generic/include/odp/atomic.h
@@ -17,7 +17,6 @@ 
 extern "C" {
 #endif
 
-#include <stdint.h>
 #include <odp/align.h>
 #include <odp/plat/atomic_types.h>
 
diff --git a/platform/linux-generic/include/odp/barrier.h b/platform/linux-generic/include/odp/barrier.h
index 42df859..3447429 100644
--- a/platform/linux-generic/include/odp/barrier.h
+++ b/platform/linux-generic/include/odp/barrier.h
@@ -17,6 +17,7 @@ 
 extern "C" {
 #endif
 
+#include <odp/std_types.h>
 #include <odp/atomic.h>
 #include <odp/plat/shared_memory_types.h>
 #include <odp/plat/barrier_types.h>
diff --git a/platform/linux-generic/include/odp/plat/atomic_types.h b/platform/linux-generic/include/odp/plat/atomic_types.h
index 0f6c353..0fe15ed 100644
--- a/platform/linux-generic/include/odp/plat/atomic_types.h
+++ b/platform/linux-generic/include/odp/plat/atomic_types.h
@@ -18,6 +18,7 @@ 
 extern "C" {
 #endif
 
+#include <odp/std_types.h>
 #include <odp/align.h>
 
 /**
diff --git a/platform/linux-generic/include/odp/std_types.h b/platform/linux-generic/include/odp/std_types.h
index 1bd22ff..f509243 100644
--- a/platform/linux-generic/include/odp/std_types.h
+++ b/platform/linux-generic/include/odp/std_types.h
@@ -17,6 +17,7 @@ 
 extern "C" {
 #endif
 
+#include <stdint.h>
 #include <stddef.h>
 #include <stdbool.h>
 #include <stdint.h>