diff mbox series

ARM: dts: lan966x: Add interrupt support for PHYs on pcb8290

Message ID 20220915064112.1935051-1-horatiu.vultur@microchip.com
State Accepted
Commit a16b72612bb98a3ef6546bf52569643ddba0104f
Headers show
Series ARM: dts: lan966x: Add interrupt support for PHYs on pcb8290 | expand

Commit Message

Horatiu Vultur Sept. 15, 2022, 6:41 a.m. UTC
Add interrupt support for the PHYs found on pcb8290. They are all
sharing the same interrupt line towards lan966x.

Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
 arch/arm/boot/dts/lan966x-pcb8290.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Nicolas Ferre Sept. 30, 2022, 11:33 a.m. UTC | #1
On 15/09/2022 at 08:41, Horatiu Vultur wrote:
> Add interrupt support for the PHYs found on pcb8290. They are all
> sharing the same interrupt line towards lan966x.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>

Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>   arch/arm/boot/dts/lan966x-pcb8290.dts | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/lan966x-pcb8290.dts b/arch/arm/boot/dts/lan966x-pcb8290.dts
> index af92bb12bc6cd..2ed53da914acb 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8290.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8290.dts
> @@ -68,41 +68,57 @@ &mdio0 {
>   
>   	ext_phy0: ethernet-phy@7 {
>   		reg = <7>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy1: ethernet-phy@8 {
>   		reg = <8>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy2: ethernet-phy@9 {
>   		reg = <9>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy3: ethernet-phy@10 {
>   		reg = <10>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy4: ethernet-phy@15 {
>   		reg = <15>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy5: ethernet-phy@16 {
>   		reg = <16>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy6: ethernet-phy@17 {
>   		reg = <17>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy7: ethernet-phy@18 {
>   		reg = <18>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   };
Claudiu Beznea Oct. 26, 2022, 7:39 a.m. UTC | #2
On 15.09.2022 09:41, Horatiu Vultur wrote:
> Add interrupt support for the PHYs found on pcb8290. They are all
> sharing the same interrupt line towards lan966x.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>

Applied to at91-dt, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/lan966x-pcb8290.dts b/arch/arm/boot/dts/lan966x-pcb8290.dts
index af92bb12bc6cd..2ed53da914acb 100644
--- a/arch/arm/boot/dts/lan966x-pcb8290.dts
+++ b/arch/arm/boot/dts/lan966x-pcb8290.dts
@@ -68,41 +68,57 @@  &mdio0 {
 
 	ext_phy0: ethernet-phy@7 {
 		reg = <7>;
+		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-parent = <&gpio>;
 		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
 	};
 
 	ext_phy1: ethernet-phy@8 {
 		reg = <8>;
+		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-parent = <&gpio>;
 		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
 	};
 
 	ext_phy2: ethernet-phy@9 {
 		reg = <9>;
+		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-parent = <&gpio>;
 		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
 	};
 
 	ext_phy3: ethernet-phy@10 {
 		reg = <10>;
+		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-parent = <&gpio>;
 		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
 	};
 
 	ext_phy4: ethernet-phy@15 {
 		reg = <15>;
+		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-parent = <&gpio>;
 		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
 	};
 
 	ext_phy5: ethernet-phy@16 {
 		reg = <16>;
+		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-parent = <&gpio>;
 		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
 	};
 
 	ext_phy6: ethernet-phy@17 {
 		reg = <17>;
+		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-parent = <&gpio>;
 		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
 	};
 
 	ext_phy7: ethernet-phy@18 {
 		reg = <18>;
+		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-parent = <&gpio>;
 		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
 	};
 };