[PATCH-Android,android/external/webkit] Modified to avoid build errors using GCC 4.5/4.6.

Message ID 1300252598-1653-6-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat March 16, 2011, 5:16 a.m.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Change-Id: I2cd4ccdf7edc39b025ef39bd5db0154c616aa5a9
---
 WebKit/android/nav/FindCanvas.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

john stultz March 18, 2011, 6:53 p.m. | #1
On Wed, 2011-03-16 at 10:46 +0530, Sachin Kamat wrote:
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> 
> Change-Id: I2cd4ccdf7edc39b025ef39bd5db0154c616aa5a9
> ---
>  WebKit/android/nav/FindCanvas.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Very cool work! 
One nit: Would you mind adding a more descriptive changelog to all of
these patches? (ie: what is the error without the patch, why its a
correct change, etc).

thanks
-john

Patch

diff --git a/WebKit/android/nav/FindCanvas.cpp b/WebKit/android/nav/FindCanvas.cpp
index d8e908b..15cce43 100644
--- a/WebKit/android/nav/FindCanvas.cpp
+++ b/WebKit/android/nav/FindCanvas.cpp
@@ -98,7 +98,7 @@  GlyphSet::~GlyphSet() {
     // part of mLowerGlyphs
 }
 
-GlyphSet::GlyphSet& GlyphSet::operator=(GlyphSet& src) {
+GlyphSet& GlyphSet::operator=(GlyphSet& src) {
     mTypeface = src.mTypeface;
     mCount = src.mCount;
     if (mCount > MAX_STORAGE_COUNT) {