| Message ID | 20220920063252.215144-1-ye.xingchen@zte.com.cn |
|---|---|
| State | New |
| Headers | show |
| Series | [linux-next] crypto: ccp: Remove the unneeded result variable | expand |
On 9/20/22 1:32 AM, cgel.zte@gmail.com wrote: > From: ye xingchen <ye.xingchen@zte.com.cn> > > Return the value ccp_crypto_enqueue_request() directly instead of storing > it in another redundant variable. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > --- > drivers/crypto/ccp/ccp-crypto-des3.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/crypto/ccp/ccp-crypto-des3.c b/drivers/crypto/ccp/ccp-crypto-des3.c > index ec97daf0fcb7..278636ed251a 100644 > --- a/drivers/crypto/ccp/ccp-crypto-des3.c > +++ b/drivers/crypto/ccp/ccp-crypto-des3.c > @@ -64,7 +64,6 @@ static int ccp_des3_crypt(struct skcipher_request *req, bool encrypt) > struct ccp_des3_req_ctx *rctx = skcipher_request_ctx(req); > struct scatterlist *iv_sg = NULL; > unsigned int iv_len = 0; > - int ret; > > if (!ctx->u.des3.key_len) > return -EINVAL; > @@ -100,9 +99,7 @@ static int ccp_des3_crypt(struct skcipher_request *req, bool encrypt) > rctx->cmd.u.des3.src_len = req->cryptlen; > rctx->cmd.u.des3.dst = req->dst; > > - ret = ccp_crypto_enqueue_request(&req->base, &rctx->cmd); > - > - return ret; > + return ccp_crypto_enqueue_request(&req->base, &rctx->cmd); > } > > static int ccp_des3_encrypt(struct skcipher_request *req) Acked-by: John Allen <john.allen@amd.com>
On Tue, Sep 20, 2022 at 06:32:52AM +0000, cgel.zte@gmail.com wrote: > From: ye xingchen <ye.xingchen@zte.com.cn> > > Return the value ccp_crypto_enqueue_request() directly instead of storing > it in another redundant variable. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > --- > drivers/crypto/ccp/ccp-crypto-des3.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Patch applied. Thanks.
diff --git a/drivers/crypto/ccp/ccp-crypto-des3.c b/drivers/crypto/ccp/ccp-crypto-des3.c index ec97daf0fcb7..278636ed251a 100644 --- a/drivers/crypto/ccp/ccp-crypto-des3.c +++ b/drivers/crypto/ccp/ccp-crypto-des3.c @@ -64,7 +64,6 @@ static int ccp_des3_crypt(struct skcipher_request *req, bool encrypt) struct ccp_des3_req_ctx *rctx = skcipher_request_ctx(req); struct scatterlist *iv_sg = NULL; unsigned int iv_len = 0; - int ret; if (!ctx->u.des3.key_len) return -EINVAL; @@ -100,9 +99,7 @@ static int ccp_des3_crypt(struct skcipher_request *req, bool encrypt) rctx->cmd.u.des3.src_len = req->cryptlen; rctx->cmd.u.des3.dst = req->dst; - ret = ccp_crypto_enqueue_request(&req->base, &rctx->cmd); - - return ret; + return ccp_crypto_enqueue_request(&req->base, &rctx->cmd); } static int ccp_des3_encrypt(struct skcipher_request *req)