| Message ID | 20220924101442.33833-1-qianweili@huawei.com |
|---|---|
| State | Accepted |
| Commit | f57e292897cac13b6ddee078aea21173b234ecb7 |
| Headers | show |
| Series | crypto: hisilicon/qm - fix incorrect parameters usage | expand |
On Sat, Sep 24, 2022 at 06:14:42PM +0800, Weili Qian wrote: > In qm_get_xqc_depth(), parameters low_bits and high_bits save > the values of the corresponding bits. However, the values saved by the > two parameters are opposite. As a result, the values returned to the > callers are incorrect. > > Fixes: 129a9f340172 ("crypto: hisilicon/qm - get qp num and depth from hardware registers") > Signed-off-by: Weili Qian <qianweili@huawei.com> > --- > drivers/crypto/hisilicon/qm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks.
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 8b387de69d22..c7e7fc49ec06 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -909,8 +909,8 @@ static void qm_get_xqc_depth(struct hisi_qm *qm, u16 *low_bits, u32 depth; depth = hisi_qm_get_hw_info(qm, qm_basic_info, type, qm->cap_ver); - *high_bits = depth & QM_XQ_DEPTH_MASK; - *low_bits = (depth >> QM_XQ_DEPTH_SHIFT) & QM_XQ_DEPTH_MASK; + *low_bits = depth & QM_XQ_DEPTH_MASK; + *high_bits = (depth >> QM_XQ_DEPTH_SHIFT) & QM_XQ_DEPTH_MASK; } static u32 qm_get_irq_num(struct hisi_qm *qm)
In qm_get_xqc_depth(), parameters low_bits and high_bits save the values of the corresponding bits. However, the values saved by the two parameters are opposite. As a result, the values returned to the callers are incorrect. Fixes: 129a9f340172 ("crypto: hisilicon/qm - get qp num and depth from hardware registers") Signed-off-by: Weili Qian <qianweili@huawei.com> --- drivers/crypto/hisilicon/qm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)