[PATCH-Android,android/build] Disable Werror option to avoid build errors using GCC 4.5/4.6.

Message ID 1300252598-1653-2-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat March 16, 2011, 5:16 a.m.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Change-Id: I471e831d569b37345752d788f5a213ffd6616690
---
 core/config.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Alexander Sack March 16, 2011, 9:13 a.m. | #1
Hmm ... I think disabling Werror completely is not something we should
take into our main android branches. Sachin, were there just too many
issues in dalvik to fix them properly?

On Wed, Mar 16, 2011 at 6:16 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>  Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>
> Change-Id: I471e831d569b37345752d788f5a213ffd6616690
> ---
>  core/config.mk |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/core/config.mk b/core/config.mk
> index a76aec8..45100fb 100644
> --- a/core/config.mk
> +++ b/core/config.mk
> @@ -98,7 +98,7 @@ COMMON_JAVA_PACKAGE_SUFFIX := .jar
>  COMMON_ANDROID_PACKAGE_SUFFIX := .apk
>
>  # list of flags to turn specific warnings in to errors
> -TARGET_ERROR_FLAGS := -Werror=return-type -Werror=non-virtual-dtor -Werror=address -Werror=sequence-point
> +TARGET_ERROR_FLAGS :=
>
>  # TODO: do symbol compression
>  TARGET_COMPRESS_MODULE_SYMBOLS := false
> --
> 1.7.1
>
>
> _______________________________________________
> linaro-dev mailing list
> linaro-dev@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/linaro-dev
>

Patch

diff --git a/core/config.mk b/core/config.mk
index a76aec8..45100fb 100644
--- a/core/config.mk
+++ b/core/config.mk
@@ -98,7 +98,7 @@  COMMON_JAVA_PACKAGE_SUFFIX := .jar
 COMMON_ANDROID_PACKAGE_SUFFIX := .apk
 
 # list of flags to turn specific warnings in to errors
-TARGET_ERROR_FLAGS := -Werror=return-type -Werror=non-virtual-dtor -Werror=address -Werror=sequence-point
+TARGET_ERROR_FLAGS :=
 
 # TODO: do symbol compression
 TARGET_COMPRESS_MODULE_SYMBOLS := false