diff mbox series

[2/5] dt-bindings: arm: qcom: Document QDU1000/QRU1000 SoCs and boards

Message ID 20221001030641.29354-3-quic_molvera@quicinc.com
State New
Headers show
Series Add misc support for QDU1000/QRU1000 SoCs | expand

Commit Message

Melody Olvera Oct. 1, 2022, 3:06 a.m. UTC
Document the QDU1000 and QRU1000 SoC bindings and the boards that use
them.

Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Rob Herring Oct. 3, 2022, 1:24 p.m. UTC | #1
On Fri, 30 Sep 2022 20:06:38 -0700, Melody Olvera wrote:
> Document the QDU1000 and QRU1000 SoC bindings and the boards that use
> them.
> 
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/qcom.yaml:725:18: [error] syntax error: mapping values are not allowed here (syntax)

dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/arm/qcom.example.dts'
Documentation/devicetree/bindings/arm/qcom.yaml:725:18: mapping values are not allowed in this context
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/arm/qcom.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/arm/qcom.yaml:725:18: mapping values are not allowed in this context
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/qcom.yaml: ignoring, error parsing file
make: *** [Makefile:1420: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Melody Olvera Oct. 4, 2022, 3:16 p.m. UTC | #2
On 10/1/2022 4:26 AM, Krzysztof Kozlowski wrote:
> On 01/10/2022 05:06, Melody Olvera wrote:
>> Document the QDU1000 and QRU1000 SoC bindings and the boards that use
>> them.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++
> This patch goes with DT.
Will move to the dt PS.
>
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index fb1d00bcc847..1cfd92f4ab5d 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -61,6 +61,8 @@ description: |
>>          sm8250
>>          sm8350
>>          sm8450
>> +        qdu1000
>> +        qru1000
>>  
>>    The 'board' element must be one of the following strings:
>>  
>> @@ -76,6 +78,7 @@ description: |
>>          mtp
>>          qrd
>>          sbc
>> +        x100
>>  
>>    The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
>>    where the minor number may be omitted when it's zero, i.e.  v1.0 is the same
>> @@ -718,6 +721,19 @@ properties:
>>                - qcom,sm8450-qrd
>>            - const: qcom,sm8450
>>  
>> +      - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform
>> +          - items:
>> +              - enum:
>> +                  - qcom,qdu1000-idp
>> +                  - qcom,qdu1000-x100
>> +              - const: qcom,qdu1000
> Wrong order - you put it in some odd place.
Will put in alphabetical order.
>
>> +
>> +      - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform
>> +          - items:
>> +              - enum:
>> +                  -qcom,qru1000-idp
> Missing space.
Whoops; will fix.
>
>> +              - const: qcom,qru1000
>> +
>>  additionalProperties: true
>>  
>>  ...
> Best regards,
> Krzysztof

Thanks,

Melody
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index fb1d00bcc847..1cfd92f4ab5d 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -61,6 +61,8 @@  description: |
         sm8250
         sm8350
         sm8450
+        qdu1000
+        qru1000
 
   The 'board' element must be one of the following strings:
 
@@ -76,6 +78,7 @@  description: |
         mtp
         qrd
         sbc
+        x100
 
   The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
   where the minor number may be omitted when it's zero, i.e.  v1.0 is the same
@@ -718,6 +721,19 @@  properties:
               - qcom,sm8450-qrd
           - const: qcom,sm8450
 
+      - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform
+          - items:
+              - enum:
+                  - qcom,qdu1000-idp
+                  - qcom,qdu1000-x100
+              - const: qcom,qdu1000
+
+      - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform
+          - items:
+              - enum:
+                  -qcom,qru1000-idp
+              - const: qcom,qru1000
+
 additionalProperties: true
 
 ...