diff mbox series

[1/2] ASoC: dt-bindings: add pin-switches to audio-graph-card2.yaml

Message ID 20221005142734.2724537-1-clca@bang-olufsen.dk
State New
Headers show
Series [1/2] ASoC: dt-bindings: add pin-switches to audio-graph-card2.yaml | expand

Commit Message

Claudio Cabral Oct. 5, 2022, 2:27 p.m. UTC 
Document support for pin-switches in audio-graph-card2
this devicetree property behaves the same way as its homonym in
simple-card

Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Signed-off-by: Claudio Cabral <clca@bang-olufsen.dk>
---
 Documentation/devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski Oct. 5, 2022, 4:06 p.m. UTC | #1 
On 05/10/2022 16:27, Claudio Cabral wrote:
> Document support for pin-switches in audio-graph-card2

Full stop?

> this devicetree property behaves the same way as its homonym in
> simple-card

Missing capital letter and full stop?

Instead please describe why do you need pin-switches in this binding...

> 
> Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>

Authorship or contributions (SoB) usually means someone reviewed it and
there is no need for both tags. The combination of both tags above is a
bit surprising.

> Signed-off-by: Claudio Cabral <clca@bang-olufsen.dk>
> ---
>  Documentation/devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++
>  1 file changed, 3 insertions(+)

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml
index 7416067c945e..ab2cc83d6b4b 100644
--- a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml
+++ b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml
@@ -32,6 +32,9 @@  properties:
   codec2codec:
     type: object
     description: Codec to Codec node
+  pin-switches:
+    description: the widget names for which pin switches must be created.
+    $ref: /schemas/types.yaml#/definitions/string-array
 
 required:
   - compatible