| Message ID | 1455008743-21660-1-git-send-email-kishon@ti.com |
|---|---|
| State | Accepted |
| Commit | 4965be1fc8dbb3dfc8bf401c78cb78c35d5d0d4d |
| Headers | show |
Hi, On Tuesday 09 February 2016 02:48 PM, Paul Walmsley wrote: > On Tue, 9 Feb 2016, Kishon Vijay Abraham I wrote: > >> OCP2SCP doesn't support smart idle wakeup according to >> Table 26-22. OCP2SCP_SYSCONFIG in AM572x TRM [1] and >> Table 26-22. OCP2SCP_SYSCONFIG in AM571x TRM [2]. >> Remove SIDLE_SMART_WKUP from the list of supported SIDLE modes >> in hwmod data. >> >> [1] -> http://www.ti.com/lit/ug/spruhz6e/spruhz6e.pdf >> [2] -> http://www.ti.com/lit/ug/spruhz7a/spruhz7a.pdf >> >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > > Thanks, queued for v4.6. If you'd like it queued as a fix, please resend > with a description of the regression that it fixes. Found this during review and as such it didn't cause any regressions. So I think it's okay to be queued for 4.6 Thanks Kishon
diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c index 848356e..84c2699 100644 --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c @@ -1482,8 +1482,7 @@ static struct omap_hwmod_class_sysconfig dra7xx_ocp2scp_sysc = { .syss_offs = 0x0014, .sysc_flags = (SYSC_HAS_AUTOIDLE | SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET | SYSS_HAS_RESET_STATUS), - .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | - SIDLE_SMART_WKUP), + .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), .sysc_fields = &omap_hwmod_sysc_type1, };
OCP2SCP doesn't support smart idle wakeup according to Table 26-22. OCP2SCP_SYSCONFIG in AM572x TRM [1] and Table 26-22. OCP2SCP_SYSCONFIG in AM571x TRM [2]. Remove SIDLE_SMART_WKUP from the list of supported SIDLE modes in hwmod data. [1] -> http://www.ti.com/lit/ug/spruhz6e/spruhz6e.pdf [2] -> http://www.ti.com/lit/ug/spruhz7a/spruhz7a.pdf Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- Changes from v1: *) Updated commit log to use public TRM links. arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 1.7.9.5