mbox series

[GIT,PULL] Crypto Fixes for 6.1

Message ID Y0zcWCmNmdXnX8RP@gondor.apana.org.au
State New
Headers show
Series [GIT,PULL] Crypto Fixes for 6.1 | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git tags/v6.1-p2

Message

Herbert Xu Oct. 17, 2022, 4:38 a.m. UTC
Hi Linus:

The following changes since commit b411b1a0c8bddd470fc8c3457629ac25a168cba0:

  crypto: aspeed - Remove redundant dev_err call (2022-09-30 13:59:13 +0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git tags/v6.1-p2

for you to fetch changes up to 96cb9d0554457086664d3bd10630b11193d863f1:

  hwrng: bcm2835 - use hwrng_msleep() instead of cpu_relax() (2022-10-14 19:03:09 +0800)

----------------------------------------------------------------
This push fixes an issue exposed by the recent change to feed
untrusted sources into /dev/random.
----------------------------------------------------------------

Jason A. Donenfeld (1):
      hwrng: bcm2835 - use hwrng_msleep() instead of cpu_relax()

 drivers/char/hw_random/bcm2835-rng.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,

Comments

Linus Torvalds Oct. 28, 2022, 5 p.m. UTC | #1
On Thu, Oct 27, 2022 at 9:58 PM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> This push fixes an alignment crash in x86/polyval.

I'm surprised that there isn't a cra_ctxalignment field. Instead there
is crypto_tfm_ctx_alignment(), but that is just an odd way to write
CRYPTO_MINALIGN.

            Linus
pr-tracker-bot@kernel.org Oct. 28, 2022, 5:02 p.m. UTC | #2
The pull request you sent on Fri, 28 Oct 2022 12:58:15 +0800:

> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git tags/v6.1-p3

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/05c31d25cc9678cc173cf12e259d638e8a641f66

Thank you!
Herbert Xu Nov. 2, 2022, 9:49 a.m. UTC | #3
On Fri, Oct 28, 2022 at 10:00:34AM -0700, Linus Torvalds wrote:
> 
> I'm surprised that there isn't a cra_ctxalignment field. Instead there
> is crypto_tfm_ctx_alignment(), but that is just an odd way to write
> CRYPTO_MINALIGN.

It's a micro-optimisation to elide the align operaton because
most algorithms don't need it.

I've been meaning to add a helper for it though:

https://lore.kernel.org/all/E1noNhu-00BzV4-4N@fornost.hmeau.com/

But I got side tracked by the vacillating DMA discussion.

Cheers,