| Message ID | 20221020021656.2092938-1-yangyingliang@huawei.com |
|---|---|
| State | Accepted |
| Commit | 0d75da38e060d21f948b3df5f5e349c962cf1ed2 |
| Headers | show |
| Series | [v3] Bluetooth: hci_core: fix error handling in hci_register_dev() | expand |
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c index 0540555b3704..9d9fb3dff22a 100644 --- a/net/bluetooth/hci_core.c +++ b/net/bluetooth/hci_core.c @@ -2660,7 +2660,7 @@ int hci_register_dev(struct hci_dev *hdev) error = hci_register_suspend_notifier(hdev); if (error) - goto err_wqueue; + BT_WARN("register suspend notifier failed error:%d\n", error); queue_work(hdev->req_workqueue, &hdev->power_on);
If hci_register_suspend_notifier() returns error, the hdev and rfkill are leaked. We could disregard the error and print a warning message instead to avoid leaks, as it just means we won't be handing suspend requests. Fixes: 9952d90ea288 ("Bluetooth: Handle PM_SUSPEND_PREPARE and PM_POST_SUSPEND") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- v2 -> v3: print a warning message instead of goto err v1 -> v2: Add rfkill_destroy(). --- net/bluetooth/hci_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)