| Message ID | 1455210808-29395-3-git-send-email-sudeep.holla@arm.com |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, 11 Feb 2016, Sudeep Holla wrote: > Underscores are usually forbidden in the compatible strings. So lets > remove it before the first users of this is seen. > > Cc: Jassi Brar <jassisinghbrar@gmail.com> > Cc: Lee Jones <lee.jones@linaro.org> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Acked-by: Lee Jones <lee.jones@linaro.org> > --- > Documentation/devicetree/bindings/mailbox/sti-mailbox.txt | 2 +- > drivers/mailbox/mailbox-test.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt > index b61eec920359..351f612673fc 100644 > --- a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt > +++ b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt > @@ -44,7 +44,7 @@ Optional properties > Example: > > mailbox_test { > - compatible = "mailbox_test"; > + compatible = "mailbox-test"; > reg = <0x[shared_memory_address], [shared_memory_size]>; > mboxes = <&mailbox2 0 1>, <&mailbox0 2 1>; > mbox-names = "tx", "rx"; > diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c > index 3813f6d9eba9..036a852b5fa1 100644 > --- a/drivers/mailbox/mailbox-test.c > +++ b/drivers/mailbox/mailbox-test.c > @@ -342,7 +342,7 @@ static int mbox_test_remove(struct platform_device *pdev) > } > > static const struct of_device_id mbox_test_match[] = { > - { .compatible = "mailbox_test" }, > + { .compatible = "mailbox-test" }, > {}, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
diff --git a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt index b61eec920359..351f612673fc 100644 --- a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt +++ b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt @@ -44,7 +44,7 @@ Optional properties Example: mailbox_test { - compatible = "mailbox_test"; + compatible = "mailbox-test"; reg = <0x[shared_memory_address], [shared_memory_size]>; mboxes = <&mailbox2 0 1>, <&mailbox0 2 1>; mbox-names = "tx", "rx"; diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c index 3813f6d9eba9..036a852b5fa1 100644 --- a/drivers/mailbox/mailbox-test.c +++ b/drivers/mailbox/mailbox-test.c @@ -342,7 +342,7 @@ static int mbox_test_remove(struct platform_device *pdev) } static const struct of_device_id mbox_test_match[] = { - { .compatible = "mailbox_test" }, + { .compatible = "mailbox-test" }, {}, };
Underscores are usually forbidden in the compatible strings. So lets remove it before the first users of this is seen. Cc: Jassi Brar <jassisinghbrar@gmail.com> Cc: Lee Jones <lee.jones@linaro.org> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- Documentation/devicetree/bindings/mailbox/sti-mailbox.txt | 2 +- drivers/mailbox/mailbox-test.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 1.9.1