| Message ID | 20221028155633.1.I6c4bfb31e88fad934e7360242cb662e01612c1bb@changeid |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: sdhci-pci: Set PROBE_PREFER_ASYNCHRONOUS | expand |
On 29/10/22 01:56, Brian Norris wrote: > This driver often takes on the order of 10ms to start, but in some cases > as much as 190ms. It shouldn't have many cross-device dependencies to > race with, nor racy access to shared state with other drivers, so this > should be a relatively low risk change. We've done similarly with a > variety of other MMC host drivers already. > > This driver was pinpointed as part of a survey of top slowest initcalls > (i.e., are built in, and probing synchronously) on a lab of ChromeOS > systems. > > Signed-off-by: Brian Norris <briannorris@chromium.org> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > > drivers/mmc/host/sdhci-pci-core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c > index 34ea1acbb3cc..0449630acbb3 100644 > --- a/drivers/mmc/host/sdhci-pci-core.c > +++ b/drivers/mmc/host/sdhci-pci-core.c > @@ -2281,7 +2281,8 @@ static struct pci_driver sdhci_driver = { > .probe = sdhci_pci_probe, > .remove = sdhci_pci_remove, > .driver = { > - .pm = &sdhci_pci_pm_ops > + .pm = &sdhci_pci_pm_ops, > + .probe_type = PROBE_PREFER_ASYNCHRONOUS, > }, > }; >
On Sat, 29 Oct 2022 at 00:56, Brian Norris <briannorris@chromium.org> wrote: > > This driver often takes on the order of 10ms to start, but in some cases > as much as 190ms. It shouldn't have many cross-device dependencies to > race with, nor racy access to shared state with other drivers, so this > should be a relatively low risk change. We've done similarly with a > variety of other MMC host drivers already. > > This driver was pinpointed as part of a survey of top slowest initcalls > (i.e., are built in, and probing synchronously) on a lab of ChromeOS > systems. > > Signed-off-by: Brian Norris <briannorris@chromium.org> Applied for next, thanks! Kind regards Uffe > --- > > drivers/mmc/host/sdhci-pci-core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c > index 34ea1acbb3cc..0449630acbb3 100644 > --- a/drivers/mmc/host/sdhci-pci-core.c > +++ b/drivers/mmc/host/sdhci-pci-core.c > @@ -2281,7 +2281,8 @@ static struct pci_driver sdhci_driver = { > .probe = sdhci_pci_probe, > .remove = sdhci_pci_remove, > .driver = { > - .pm = &sdhci_pci_pm_ops > + .pm = &sdhci_pci_pm_ops, > + .probe_type = PROBE_PREFER_ASYNCHRONOUS, > }, > }; > > -- > 2.38.1.273.g43a17bfeac-goog >
diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c index 34ea1acbb3cc..0449630acbb3 100644 --- a/drivers/mmc/host/sdhci-pci-core.c +++ b/drivers/mmc/host/sdhci-pci-core.c @@ -2281,7 +2281,8 @@ static struct pci_driver sdhci_driver = { .probe = sdhci_pci_probe, .remove = sdhci_pci_remove, .driver = { - .pm = &sdhci_pci_pm_ops + .pm = &sdhci_pci_pm_ops, + .probe_type = PROBE_PREFER_ASYNCHRONOUS, }, };
This driver often takes on the order of 10ms to start, but in some cases as much as 190ms. It shouldn't have many cross-device dependencies to race with, nor racy access to shared state with other drivers, so this should be a relatively low risk change. We've done similarly with a variety of other MMC host drivers already. This driver was pinpointed as part of a survey of top slowest initcalls (i.e., are built in, and probing synchronously) on a lab of ChromeOS systems. Signed-off-by: Brian Norris <briannorris@chromium.org> --- drivers/mmc/host/sdhci-pci-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)