| Message ID | 4311e9cb62687449f4175e2b062abcd77aada059.1667336095.git.christophe.jaillet@wanadoo.fr |
|---|---|
| State | Accepted |
| Commit | 60f07c29e035b2554db951b494dd804317c230d3 |
| Headers | show |
| Series | None | expand |
On Tue, Nov 01, 2022 at 10:14:00PM +0100, Christophe JAILLET wrote: > strtobool() is the same as kstrtobool(). > However, the latter is more used within the kernel. > > In order to remove strtobool() and slightly simplify kstrtox.h, switch to > the other function name. > > While at it, include the corresponding header file (<linux/kstrtox.h>) > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Please feel free to merge with the rest of the series. Or let me know if you want me to pick just this one through my tree. Thanks.
Le 03/11/2022 à 21:46, Dmitry Torokhov a écrit : > On Tue, Nov 01, 2022 at 10:14:00PM +0100, Christophe JAILLET wrote: >> strtobool() is the same as kstrtobool(). >> However, the latter is more used within the kernel. >> >> In order to remove strtobool() and slightly simplify kstrtox.h, switch to >> the other function name. >> >> While at it, include the corresponding header file (<linux/kstrtox.h>) >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > Please feel free to merge with the rest of the series. Or let me know if > you want me to pick just this one through my tree. > > Thanks. > Hi, the patch can go through your tree. There is no plan to merge the whole serie at once, and some other maintainers have asked for some patches to be re-sent as individual patches. CJ
diff --git a/drivers/input/input.c b/drivers/input/input.c index ebb2b7f0f8ff..783961df3626 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c @@ -21,6 +21,7 @@ #include <linux/seq_file.h> #include <linux/poll.h> #include <linux/device.h> +#include <linux/kstrtox.h> #include <linux/mutex.h> #include <linux/rcupdate.h> #include "input-compat.h" @@ -1465,7 +1466,7 @@ static ssize_t inhibited_store(struct device *dev, ssize_t rv; bool inhibited; - if (strtobool(buf, &inhibited)) + if (kstrtobool(buf, &inhibited)) return -EINVAL; if (inhibited)
strtobool() is the same as kstrtobool(). However, the latter is more used within the kernel. In order to remove strtobool() and slightly simplify kstrtox.h, switch to the other function name. While at it, include the corresponding header file (<linux/kstrtox.h>) Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- This patch is part of a serie that axes all usages of strtobool(). Each patch can be applied independently from the other ones. The last patch of the serie removes the definition of strtobool(). You may not be in copy of the cover letter. So, if needed, it is available at [1]. [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/ --- drivers/input/input.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)