| Message ID | 20221117145656.395056-1-yangyingliang@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | of: property: fix unbalanced of node refcount in of_fwnode_get_reference_args() | expand |
diff --git a/drivers/of/property.c b/drivers/of/property.c index 967f79b59016..134cfc980b70 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -993,8 +993,10 @@ of_fwnode_get_reference_args(const struct fwnode_handle *fwnode, nargs, index, &of_args); if (ret < 0) return ret; - if (!args) + if (!args) { + of_node_put(of_args.np); return 0; + } args->nargs = of_args.args_count; args->fwnode = of_fwnode_handle(of_args.np);
I got the the following report: OF: ERROR: memory leak, expected refcount 1 instead of 4, of_node_get()/of_node_put() unbalanced - destroy cset entry: attach overlay node /i2c/pmic@34/adc In of_fwnode_get_reference_args(), the 'of_args.np' returned from of_parse_phandle_with_args(), its refcount is increased in of_phandle_iterator_next(), if args is null, the refcount of 'of_args.np' need be put to avoid leak. Fixes: 3e3119d3088f ("device property: Introduce fwnode_property_get_reference_args") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/of/property.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)