From patchwork Tue Feb 23 01:22:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Muckle X-Patchwork-Id: 62647 Delivered-To: patch@linaro.org Received: by 10.112.43.199 with SMTP id y7csp1568347lbl; Mon, 22 Feb 2016 17:23:39 -0800 (PST) X-Received: by 10.66.61.204 with SMTP id s12mr1616626par.108.1456190619100; Mon, 22 Feb 2016 17:23:39 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b27si43333284pfd.82.2016.02.22.17.23.37; Mon, 22 Feb 2016 17:23:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=pass header.i=@linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932447AbcBWBXS (ORCPT + 30 others); Mon, 22 Feb 2016 20:23:18 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:33495 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932319AbcBWBXE (ORCPT ); Mon, 22 Feb 2016 20:23:04 -0500 Received: by mail-pa0-f52.google.com with SMTP id fl4so100466238pad.0 for ; Mon, 22 Feb 2016 17:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eaaRgZCiVdVHrAO4+5m+iQbzM73gQg7n5LzR2+pmlto=; b=cqTClh58M0m+uTEFIorlyD4BqWUPJbVMmRWTXjjlo/pmtA5JmcVJPzjscSjXY+88l+ XNZ0YvdiK0XNHWCLGj2CmlLiKF+eLkhLgcctGksnNN6sLuuEiION9Qi1YO9/MXfDqKJp 0Ff1X1+BoahvCYhnAsGy3Ir37rv3XECHqtse0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eaaRgZCiVdVHrAO4+5m+iQbzM73gQg7n5LzR2+pmlto=; b=WT6DIqh7Shqs3GYydZRR9ELDIjTmEZ/eQyp5OLxiZcnH9ad1DAlnQB0sZfvr1E0Mjd /wCOVTlFuF/CNnQipE5TjLxPlm6HNP64cMTkcHsNd4G3CID7etWzGKV9gA3km+xtbi0H GkEITN6a1pSgvTRx3zRysvD6Q08DkEjKVNakzsuxca78syP+gtndpLVKiAcuCnmULXO4 XyDBhFrjCBKAcjCkluO2AOyPORKNOPYELlst54idXnMKnuaVacrGF98qQQ1EScXAUTNn t3m/Dk+MAc8j77oSsjGtOxEvHcto8B2UWO4oQQwhLTBUBLQejMfFlGD9DrEUk7uUy/KZ lM+Q== X-Gm-Message-State: AG10YORXVbHbluGUT1Nj31OPdfFVtptnHe06s8rK02F7WP1Fg6+AI2KVhym9fUJHTptD9rSd X-Received: by 10.66.233.131 with SMTP id tw3mr43116914pac.89.1456190584142; Mon, 22 Feb 2016 17:23:04 -0800 (PST) Received: from graphite.smuckle.net (cpe-75-80-155-7.san.res.rr.com. [75.80.155.7]) by smtp.gmail.com with ESMTPSA id t29sm39626789pfi.8.2016.02.22.17.23.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 22 Feb 2016 17:23:03 -0800 (PST) From: Steve Muckle X-Google-Original-From: Steve Muckle To: Peter Zijlstra , Ingo Molnar , "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Juri Lelli , Patrick Bellasi , Michael Turquette Subject: [RFCv7 PATCH 08/10] sched: remove call of sched_avg_update from sched_rt_avg_update Date: Mon, 22 Feb 2016 17:22:48 -0800 Message-Id: <1456190570-4475-9-git-send-email-smuckle@linaro.org> X-Mailer: git-send-email 2.4.10 In-Reply-To: <1456190570-4475-1-git-send-email-smuckle@linaro.org> References: <1456190570-4475-1-git-send-email-smuckle@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vincent Guittot rt_avg is only used to scale the available CPU's capacity for CFS tasks. As the update of this scaling is done during periodic load balance, we only have to ensure that sched_avg_update has been called before any periodic load balancing. This requirement is already fulfilled by __update_cpu_load so the call in sched_rt_avg_update, which is part of the hotpath, is useless. Signed-off-by: Vincent Guittot Signed-off-by: Steve Muckle --- kernel/sched/sched.h | 1 - 1 file changed, 1 deletion(-) -- 2.4.10 diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 59747d8..3df21f2 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1498,7 +1498,6 @@ static inline void set_dl_cpu_capacity(int cpu, bool request, static inline void sched_rt_avg_update(struct rq *rq, u64 rt_delta) { rq->rt_avg += rt_delta * arch_scale_freq_capacity(NULL, cpu_of(rq)); - sched_avg_update(rq); } #else static inline void sched_rt_avg_update(struct rq *rq, u64 rt_delta) { }