| Message ID | 20221118084254.1880165-1-benjamin.tissoires@redhat.com |
|---|---|
| State | Accepted |
| Commit | 6cc90ccd4f6cfed98e2a3a378debc69f28d57473 |
| Headers | show |
| Series | [hid-next] HID: fix BT_HIDP Kconfig dependencies | expand |
On Fri, 18 Nov 2022, Benjamin Tissoires wrote: > If HID_SUPPORT is not selected, BT_HIDP should not be available, simply > because we disallowed the HID bus entirely. > > Add a new depends and actually revert this file back to where it was 10 > years ago before it was changed by commit 1f41a6a99476 ("HID: Fix the > generic Kconfig options"). > > Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation") > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/r/202211181514.fLhaiS7o-lkp@intel.com/ > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Applied to for-6.2/hid-bpf.
diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig index 14100f341f33..6746be07e222 100644 --- a/net/bluetooth/hidp/Kconfig +++ b/net/bluetooth/hidp/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config BT_HIDP tristate "HIDP protocol support" - depends on BT_BREDR && INPUT + depends on BT_BREDR && INPUT && HID_SUPPORT select HID help HIDP (Human Interface Device Protocol) is a transport layer
If HID_SUPPORT is not selected, BT_HIDP should not be available, simply because we disallowed the HID bus entirely. Add a new depends and actually revert this file back to where it was 10 years ago before it was changed by commit 1f41a6a99476 ("HID: Fix the generic Kconfig options"). Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation") Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/r/202211181514.fLhaiS7o-lkp@intel.com/ Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> --- net/bluetooth/hidp/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)