diff mbox series

mmc: mmc_test: fix missing assignment of 'file' when register debugfs file

Message ID 20221123095506.1965691-1-yebin@huaweicloud.com
State New
Headers show
Series mmc: mmc_test: fix missing assignment of 'file' when register debugfs file | expand

Commit Message

Ye Bin Nov. 23, 2022, 9:55 a.m. UTC 
From: Ye Bin <yebin10@huawei.com>

Now, 'file' is always NULL. obviously, 'file' is used to store return value of
'debugfs_create_file()'.

Fixes: a04c50aaa916 ("mmc: core: no need to check return value of debugfs_create functions")
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
 drivers/mmc/core/mmc_test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Adrian Hunter Nov. 23, 2022, 10:54 a.m. UTC | #1 
On 23/11/22 11:55, Ye Bin wrote:
> From: Ye Bin <yebin10@huawei.com>
> 
> Now, 'file' is always NULL. obviously, 'file' is used to store return value of
> 'debugfs_create_file()'.

'file' is used to remove debugfs files when the mmc_test module is removed.

> 
> Fixes: a04c50aaa916 ("mmc: core: no need to check return value of debugfs_create functions")
> Signed-off-by: Ye Bin <yebin10@huawei.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/core/mmc_test.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index 6cd6f8a94a71..156d34b2ed4d 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -3174,7 +3174,8 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card,
>  	struct mmc_test_dbgfs_file *df;
>  
>  	if (card->debugfs_root)
> -		debugfs_create_file(name, mode, card->debugfs_root, card, fops);
> +		file = debugfs_create_file(name, mode, card->debugfs_root,
> +					   card, fops);
>  
>  	df = kmalloc(sizeof(*df), GFP_KERNEL);
>  	if (!df) {
Ulf Hansson Nov. 29, 2022, 12:54 p.m. UTC | #2 
On Wed, 23 Nov 2022 at 10:34, Ye Bin <yebin@huaweicloud.com> wrote:
>
> From: Ye Bin <yebin10@huawei.com>
>
> Now, 'file' is always NULL. obviously, 'file' is used to store return value of
> 'debugfs_create_file()'.
>
> Fixes: a04c50aaa916 ("mmc: core: no need to check return value of debugfs_create functions")
> Signed-off-by: Ye Bin <yebin10@huawei.com>

Applied for fixes, by amending the commit message and by adding a
stable tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/core/mmc_test.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index 6cd6f8a94a71..156d34b2ed4d 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -3174,7 +3174,8 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card,
>         struct mmc_test_dbgfs_file *df;
>
>         if (card->debugfs_root)
> -               debugfs_create_file(name, mode, card->debugfs_root, card, fops);
> +               file = debugfs_create_file(name, mode, card->debugfs_root,
> +                                          card, fops);
>
>         df = kmalloc(sizeof(*df), GFP_KERNEL);
>         if (!df) {
> --
> 2.31.1
>
diff mbox series

Patch

diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
index 6cd6f8a94a71..156d34b2ed4d 100644
--- a/drivers/mmc/core/mmc_test.c
+++ b/drivers/mmc/core/mmc_test.c
@@ -3174,7 +3174,8 @@  static int __mmc_test_register_dbgfs_file(struct mmc_card *card,
 	struct mmc_test_dbgfs_file *df;
 
 	if (card->debugfs_root)
-		debugfs_create_file(name, mode, card->debugfs_root, card, fops);
+		file = debugfs_create_file(name, mode, card->debugfs_root,
+					   card, fops);
 
 	df = kmalloc(sizeof(*df), GFP_KERNEL);
 	if (!df) {