diff mbox series

[v1] arm64: dts: verdin-imx8mm: fix dev board audio playback

Message ID 20221207102749.180485-1-francesco@dolcini.it
State New
Headers show
Series [v1] arm64: dts: verdin-imx8mm: fix dev board audio playback | expand

Commit Message

Francesco Dolcini Dec. 7, 2022, 10:27 a.m. UTC 
From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>

Set optional `simple-audio-card,mclk-fs` parameter to ensure a proper
clock to the nau8822 audio codec. Without this change with an audio
stream rate of 44.1 kHz the playback is faster.
Set the MCLK at the right frequency, codec can properly use it to
generate 44.1 kHz I2S-FS.

Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Fabio Estevam Dec. 8, 2022, 1:18 a.m. UTC | #1 
On Wed, Dec 7, 2022 at 7:27 AM Francesco Dolcini <francesco@dolcini.it> wrote:
>
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
>
> Set optional `simple-audio-card,mclk-fs` parameter to ensure a proper
> clock to the nau8822 audio codec. Without this change with an audio
> stream rate of 44.1 kHz the playback is faster.
> Set the MCLK at the right frequency, codec can properly use it to
> generate 44.1 kHz I2S-FS.
>
> Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Shawn Guo Dec. 31, 2022, 12:53 p.m. UTC | #2 
On Wed, Dec 07, 2022 at 11:27:49AM +0100, Francesco Dolcini wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> 
> Set optional `simple-audio-card,mclk-fs` parameter to ensure a proper
> clock to the nau8822 audio codec. Without this change with an audio
> stream rate of 44.1 kHz the playback is faster.
> Set the MCLK at the right frequency, codec can properly use it to
> generate 44.1 kHz I2S-FS.
> 
> Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi
index 73cc3fafa018..b2bcd2282170 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi
@@ -11,6 +11,7 @@  sound_card: sound-card {
 		simple-audio-card,bitclock-master = <&dailink_master>;
 		simple-audio-card,format = "i2s";
 		simple-audio-card,frame-master = <&dailink_master>;
+		simple-audio-card,mclk-fs = <256>;
 		simple-audio-card,name = "imx8mm-nau8822";
 		simple-audio-card,routing =
 			"Headphones", "LHP",