diff mbox series

HID: logitech-hidpp: Add constants for HID++ 2.0 error codes

Message ID 20221207100033.64095-1-hadess@hadess.net
State Accepted
Commit 43551d9bea826cec4a40a98984ae2db6dac476b3
Headers show
Series HID: logitech-hidpp: Add constants for HID++ 2.0 error codes | expand

Commit Message

Bastien Nocera Dec. 7, 2022, 10 a.m. UTC
Add constants for HID++ 2.0 error codes listed in "Protocol HID++2.0
essential features" chapter, page 3, in
logitech_hidpp_2.0_specification_draft_2012-06-04.pdf

Signed-off-by: Bastien Nocera <hadess@hadess.net>
---
 drivers/hid/hid-logitech-hidpp.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Benjamin Tissoires Feb. 6, 2023, 1:55 p.m. UTC | #1
On Wed, 07 Dec 2022 11:00:33 +0100, Bastien Nocera wrote:
> Add constants for HID++ 2.0 error codes listed in "Protocol HID++2.0
> essential features" chapter, page 3, in
> logitech_hidpp_2.0_specification_draft_2012-06-04.pdf
> 
> 

Applied to hid/hid.git (for-6.3/logitech), thanks!

[1/1] HID: logitech-hidpp: Add constants for HID++ 2.0 error codes
      https://git.kernel.org/hid/hid/c/76823bf3d650

Cheers,
diff mbox series

Patch

diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 71a9c258a20b..4c327969545f 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -225,6 +225,16 @@  struct hidpp_device {
 #define HIDPP_ERROR_INVALID_PARAM_VALUE		0x0b
 #define HIDPP_ERROR_WRONG_PIN_CODE		0x0c
 /* HID++ 2.0 error codes */
+#define HIDPP20_ERROR_NO_ERROR			0x00
+#define HIDPP20_ERROR_UNKNOWN			0x01
+#define HIDPP20_ERROR_INVALID_ARGS		0x02
+#define HIDPP20_ERROR_OUT_OF_RANGE		0x03
+#define HIDPP20_ERROR_HW_ERROR			0x04
+#define HIDPP20_ERROR_LOGITECH_INTERNAL		0x05
+#define HIDPP20_ERROR_INVALID_FEATURE_INDEX	0x06
+#define HIDPP20_ERROR_INVALID_FUNCTION_ID	0x07
+#define HIDPP20_ERROR_BUSY			0x08
+#define HIDPP20_ERROR_UNSUPPORTED		0x09
 #define HIDPP20_ERROR				0xff
 
 static void hidpp_connect_event(struct hidpp_device *hidpp_dev);