[edk2] Platforms/ARM: ArmVexpress.dsc.inc - update debug levels

Message ID 1456774456-22023-1-git-send-email-leif.lindholm@linaro.org
State New
Headers show

Commit Message

Leif Lindholm Feb. 29, 2016, 7:34 p.m.
The comments on PcdDebugPrintErrorLevel are clearly based on a version
of MdePkg/Include/Library/DebugLib.h predating SVN r12933.
Bring up to date to reduce confusion (and fix a couple of mistakes).

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

---
 Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

-- 
2.1.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Laszlo Ersek Feb. 29, 2016, 7:46 p.m. | #1
On 02/29/16 20:34, Leif Lindholm wrote:
> The comments on PcdDebugPrintErrorLevel are clearly based on a version

> of MdePkg/Include/Library/DebugLib.h predating SVN r12933.

> Bring up to date to reduce confusion (and fix a couple of mistakes).

> 

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---

>  Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 9 +++++----

>  1 file changed, 5 insertions(+), 4 deletions(-)

> 

> diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc

> index 61912ef..7d07d39 100644

> --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc

> +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc

> @@ -344,19 +344,20 @@

>    #  DEBUG_WARN      0x00000002  // Warnings

>    #  DEBUG_LOAD      0x00000004  // Load events

>    #  DEBUG_FS        0x00000008  // EFI File system

> -  #  DEBUG_POOL      0x00000010  // Alloc & Free's

> -  #  DEBUG_PAGE      0x00000020  // Alloc & Free's

> -  #  DEBUG_INFO      0x00000040  // Verbose

> +  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)

> +  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)

> +  #  DEBUG_INFO      0x00000040  // Informational debug messages

>    #  DEBUG_DISPATCH  0x00000080  // PEI/DXE Dispatchers

>    #  DEBUG_VARIABLE  0x00000100  // Variable

>    #  DEBUG_BM        0x00000400  // Boot Manager

>    #  DEBUG_BLKIO     0x00001000  // BlkIo Driver

>    #  DEBUG_NET       0x00004000  // SNI Driver

>    #  DEBUG_UNDI      0x00010000  // UNDI Driver

> -  #  DEBUG_LOADFILE  0x00020000  // UNDI Driver

> +  #  DEBUG_LOADFILE  0x00020000  // LoadFile

>    #  DEBUG_EVENT     0x00080000  // Event messages

>    #  DEBUG_GCD       0x00100000  // Global Coherency Database changes

>    #  DEBUG_CACHE     0x00200000  // Memory range cachability changes

> +  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may significantly impact boot performance

>    #  DEBUG_ERROR     0x80000000  // Error

>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F

>  

> 


Care to update DEBUG_POOL, DEBUG_PAGE, and DEBUG_LOADFILE in
"MdePkg/Include/Library/DebugLib.h" first? The above patch brings
"ArmVExpress.dsc.inc" in synch with "DebugLib.h" for DEBUG_INFO and
DEBUG_VERBOSE, but for the rest, it makes "ArmVExpress.dsc.inc" surpass
"DebugLib.h".

Thanks
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Laszlo Ersek Feb. 29, 2016, 8:14 p.m. | #2
On 02/29/16 20:34, Leif Lindholm wrote:
> The comments on PcdDebugPrintErrorLevel are clearly based on a version

> of MdePkg/Include/Library/DebugLib.h predating SVN r12933.

> Bring up to date to reduce confusion (and fix a couple of mistakes).

> 

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---

>  Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 9 +++++----

>  1 file changed, 5 insertions(+), 4 deletions(-)

> 

> diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc

> index 61912ef..7d07d39 100644

> --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc

> +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc

> @@ -344,19 +344,20 @@

>    #  DEBUG_WARN      0x00000002  // Warnings

>    #  DEBUG_LOAD      0x00000004  // Load events

>    #  DEBUG_FS        0x00000008  // EFI File system

> -  #  DEBUG_POOL      0x00000010  // Alloc & Free's

> -  #  DEBUG_PAGE      0x00000020  // Alloc & Free's

> -  #  DEBUG_INFO      0x00000040  // Verbose

> +  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)

> +  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)

> +  #  DEBUG_INFO      0x00000040  // Informational debug messages

>    #  DEBUG_DISPATCH  0x00000080  // PEI/DXE Dispatchers

>    #  DEBUG_VARIABLE  0x00000100  // Variable

>    #  DEBUG_BM        0x00000400  // Boot Manager

>    #  DEBUG_BLKIO     0x00001000  // BlkIo Driver

>    #  DEBUG_NET       0x00004000  // SNI Driver

>    #  DEBUG_UNDI      0x00010000  // UNDI Driver

> -  #  DEBUG_LOADFILE  0x00020000  // UNDI Driver

> +  #  DEBUG_LOADFILE  0x00020000  // LoadFile

>    #  DEBUG_EVENT     0x00080000  // Event messages

>    #  DEBUG_GCD       0x00100000  // Global Coherency Database changes

>    #  DEBUG_CACHE     0x00200000  // Memory range cachability changes

> +  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may significantly impact boot performance

>    #  DEBUG_ERROR     0x80000000  // Error

>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F

>  

> 


With the other patch:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Laszlo Ersek March 1, 2016, 9:05 a.m. | #3
On 02/29/16 21:14, Laszlo Ersek wrote:
> On 02/29/16 20:34, Leif Lindholm wrote:

>> The comments on PcdDebugPrintErrorLevel are clearly based on a version

>> of MdePkg/Include/Library/DebugLib.h predating SVN r12933.

>> Bring up to date to reduce confusion (and fix a couple of mistakes).

>>

>> Contributed-under: TianoCore Contribution Agreement 1.0

>> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

>> ---

>>  Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 9 +++++----

>>  1 file changed, 5 insertions(+), 4 deletions(-)

>>

>> diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc

>> index 61912ef..7d07d39 100644

>> --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc

>> +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc

>> @@ -344,19 +344,20 @@

>>    #  DEBUG_WARN      0x00000002  // Warnings

>>    #  DEBUG_LOAD      0x00000004  // Load events

>>    #  DEBUG_FS        0x00000008  // EFI File system

>> -  #  DEBUG_POOL      0x00000010  // Alloc & Free's

>> -  #  DEBUG_PAGE      0x00000020  // Alloc & Free's

>> -  #  DEBUG_INFO      0x00000040  // Verbose

>> +  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)

>> +  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)

>> +  #  DEBUG_INFO      0x00000040  // Informational debug messages

>>    #  DEBUG_DISPATCH  0x00000080  // PEI/DXE Dispatchers

>>    #  DEBUG_VARIABLE  0x00000100  // Variable

>>    #  DEBUG_BM        0x00000400  // Boot Manager

>>    #  DEBUG_BLKIO     0x00001000  // BlkIo Driver

>>    #  DEBUG_NET       0x00004000  // SNI Driver

>>    #  DEBUG_UNDI      0x00010000  // UNDI Driver

>> -  #  DEBUG_LOADFILE  0x00020000  // UNDI Driver

>> +  #  DEBUG_LOADFILE  0x00020000  // LoadFile

>>    #  DEBUG_EVENT     0x00080000  // Event messages

>>    #  DEBUG_GCD       0x00100000  // Global Coherency Database changes

>>    #  DEBUG_CACHE     0x00200000  // Memory range cachability changes

>> +  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may significantly impact boot performance

>>    #  DEBUG_ERROR     0x80000000  // Error

>>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F

>>  

>>

> 

> With the other patch:

> 

> Reviewed-by: Laszlo Ersek <lersek@redhat.com>


Let me post a "more comprehensive" patch instead.

Thanks
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm March 1, 2016, 9:38 a.m. | #4
On Tue, Mar 01, 2016 at 10:05:10AM +0100, Laszlo Ersek wrote:
> On 02/29/16 21:14, Laszlo Ersek wrote:

> > On 02/29/16 20:34, Leif Lindholm wrote:

> >> The comments on PcdDebugPrintErrorLevel are clearly based on a version

> >> of MdePkg/Include/Library/DebugLib.h predating SVN r12933.

> >> Bring up to date to reduce confusion (and fix a couple of mistakes).

> >>

> >> Contributed-under: TianoCore Contribution Agreement 1.0

> >> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

> >> ---

> >>  Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 9 +++++----

> >>  1 file changed, 5 insertions(+), 4 deletions(-)

> >>

> >> diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc

> >> index 61912ef..7d07d39 100644

> >> --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc

> >> +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc

> >> @@ -344,19 +344,20 @@

> >>    #  DEBUG_WARN      0x00000002  // Warnings

> >>    #  DEBUG_LOAD      0x00000004  // Load events

> >>    #  DEBUG_FS        0x00000008  // EFI File system

> >> -  #  DEBUG_POOL      0x00000010  // Alloc & Free's

> >> -  #  DEBUG_PAGE      0x00000020  // Alloc & Free's

> >> -  #  DEBUG_INFO      0x00000040  // Verbose

> >> +  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)

> >> +  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)

> >> +  #  DEBUG_INFO      0x00000040  // Informational debug messages

> >>    #  DEBUG_DISPATCH  0x00000080  // PEI/DXE Dispatchers

> >>    #  DEBUG_VARIABLE  0x00000100  // Variable

> >>    #  DEBUG_BM        0x00000400  // Boot Manager

> >>    #  DEBUG_BLKIO     0x00001000  // BlkIo Driver

> >>    #  DEBUG_NET       0x00004000  // SNI Driver

> >>    #  DEBUG_UNDI      0x00010000  // UNDI Driver

> >> -  #  DEBUG_LOADFILE  0x00020000  // UNDI Driver

> >> +  #  DEBUG_LOADFILE  0x00020000  // LoadFile

> >>    #  DEBUG_EVENT     0x00080000  // Event messages

> >>    #  DEBUG_GCD       0x00100000  // Global Coherency Database changes

> >>    #  DEBUG_CACHE     0x00200000  // Memory range cachability changes

> >> +  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may significantly impact boot performance

> >>    #  DEBUG_ERROR     0x80000000  // Error

> >>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F

> >>  

> >>

> > 

> > With the other patch:

> > 

> > Reviewed-by: Laszlo Ersek <lersek@redhat.com>

> 

> Let me post a "more comprehensive" patch instead.


I'm happy with that - was waiting for you guys to slug it out
overnight :)

/
    Leif
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc
index 61912ef..7d07d39 100644
--- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc
+++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc
@@ -344,19 +344,20 @@ 
   #  DEBUG_WARN      0x00000002  // Warnings
   #  DEBUG_LOAD      0x00000004  // Load events
   #  DEBUG_FS        0x00000008  // EFI File system
-  #  DEBUG_POOL      0x00000010  // Alloc & Free's
-  #  DEBUG_PAGE      0x00000020  // Alloc & Free's
-  #  DEBUG_INFO      0x00000040  // Verbose
+  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)
+  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)
+  #  DEBUG_INFO      0x00000040  // Informational debug messages
   #  DEBUG_DISPATCH  0x00000080  // PEI/DXE Dispatchers
   #  DEBUG_VARIABLE  0x00000100  // Variable
   #  DEBUG_BM        0x00000400  // Boot Manager
   #  DEBUG_BLKIO     0x00001000  // BlkIo Driver
   #  DEBUG_NET       0x00004000  // SNI Driver
   #  DEBUG_UNDI      0x00010000  // UNDI Driver
-  #  DEBUG_LOADFILE  0x00020000  // UNDI Driver
+  #  DEBUG_LOADFILE  0x00020000  // LoadFile
   #  DEBUG_EVENT     0x00080000  // Event messages
   #  DEBUG_GCD       0x00100000  // Global Coherency Database changes
   #  DEBUG_CACHE     0x00200000  // Memory range cachability changes
+  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may significantly impact boot performance
   #  DEBUG_ERROR     0x80000000  // Error
   gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F