| Message ID | 20221213115628.105149-1-konrad.dybcio@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] dt-bindings: i2c: qcom,i2c-cci: Fall back to common compatibles | expand |
On 13.12.2022 17:58, Krzysztof Kozlowski wrote: > On 13/12/2022 12:56, Konrad Dybcio wrote: >> Almost every compatible string in the CCI driver is a duplicate. Adjust >> the bindings to include a common (first-soc-implementing-vX) compatible >> to remove the need to keep adding superfluous compatible strings. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 25 +++++++++++++------ >> 1 file changed, 17 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >> index cf9f8fda595f..65cf7860a9a0 100644 >> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >> @@ -12,14 +12,23 @@ maintainers: >> >> properties: >> compatible: >> - enum: >> - - qcom,msm8226-cci >> - - qcom,msm8916-cci >> - - qcom,msm8974-cci >> - - qcom,msm8996-cci >> - - qcom,sdm845-cci >> - - qcom,sm8250-cci >> - - qcom,sm8450-cci >> + oneOf: > > Except missing test, Hm? I tested this locally with dt_binding_check and it passed.. how about also adding a comment to the driver, that > list of compatibles should not grow when not needed? Sure. Konrad > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml index cf9f8fda595f..65cf7860a9a0 100644 --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml @@ -12,14 +12,23 @@ maintainers: properties: compatible: - enum: - - qcom,msm8226-cci - - qcom,msm8916-cci - - qcom,msm8974-cci - - qcom,msm8996-cci - - qcom,sdm845-cci - - qcom,sm8250-cci - - qcom,sm8450-cci + oneOf: + - enum: + - qcom,msm8226-cci + - qcom,msm8974-cci + - qcom,msm8996-cci + + - items: + - enum: + - qcom,msm8916-cci + - const: qcom,msm8226-cci # CCI v1 + + - items: + - enum: + - qcom,sdm845-cci + - qcom,sm8250-cci + - qcom,sm8450-cci + - const: qcom,msm8996-cci # CCI v2 "#address-cells": const: 1
Almost every compatible string in the CCI driver is a duplicate. Adjust the bindings to include a common (first-soc-implementing-vX) compatible to remove the need to keep adding superfluous compatible strings. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 25 +++++++++++++------ 1 file changed, 17 insertions(+), 8 deletions(-)