| Message ID | 20221212213857.3636830-1-grundler@chromium.org |
|---|---|
| State | Accepted |
| Commit | 14c76b2e75bca4d96e2b85a0c12aa43e84fe3f74 |
| Headers | show |
| Series | power: supply: cros_usbpd: reclassify "default case!" as debug | expand |
On Mon, Dec 12, 2022 at 1:39 PM Grant Grundler <grundler@chromium.org> wrote: > > This doesn't need to be printed every second as an error: > ... > <3>[17438.628385] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: default case! > <3>[17439.634176] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: default case! > <3>[17440.640298] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: default case! > ... > > Reduce priority from ERROR to DEBUG. > > Signed-off-by: Grant Grundler <grundler@chromium.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> > > --- > drivers/power/supply/cros_usbpd-charger.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/cros_usbpd-charger.c b/drivers/power/supply/cros_usbpd-charger.c > index cadb6a0c2cc7..b6c96376776a 100644 > --- a/drivers/power/supply/cros_usbpd-charger.c > +++ b/drivers/power/supply/cros_usbpd-charger.c > @@ -276,7 +276,7 @@ static int cros_usbpd_charger_get_power_info(struct port_data *port) > port->psy_current_max = 0; > break; > default: > - dev_err(dev, "Port %d: default case!\n", port->port_number); > + dev_dbg(dev, "Port %d: default case!\n", port->port_number); > port->psy_usb_type = POWER_SUPPLY_USB_TYPE_SDP; > } > > -- > 2.39.0.rc1.256.g54fd8350bd-goog >
Hi, Thanks, queued to power-supply's fixes branch. -- Sebastian On Thu, Dec 29, 2022 at 11:53:55PM -0800, Grant Grundler wrote: > Hi Sebastian, linux-pm folks, Benson, > Can I get feedback on this patch please? > > I was just told another user feedback report had 70% of the dmesg buffer > filled with the cros-usbpd-charger output. > > cheers, > grant > > > On Mon, Dec 12, 2022 at 1:49 PM Guenter Roeck <groeck@google.com> wrote: > > > On Mon, Dec 12, 2022 at 1:39 PM Grant Grundler <grundler@chromium.org> > > wrote: > > > > > > This doesn't need to be printed every second as an error: > > > ... > > > <3>[17438.628385] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: > > default case! > > > <3>[17439.634176] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: > > default case! > > > <3>[17440.640298] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: > > default case! > > > ... > > > > > > Reduce priority from ERROR to DEBUG. > > > > > > Signed-off-by: Grant Grundler <grundler@chromium.org> > > > > Reviewed-by: Guenter Roeck <groeck@chromium.org> > > > > > > > > --- > > > drivers/power/supply/cros_usbpd-charger.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/power/supply/cros_usbpd-charger.c > > b/drivers/power/supply/cros_usbpd-charger.c > > > index cadb6a0c2cc7..b6c96376776a 100644 > > > --- a/drivers/power/supply/cros_usbpd-charger.c > > > +++ b/drivers/power/supply/cros_usbpd-charger.c > > > @@ -276,7 +276,7 @@ static int cros_usbpd_charger_get_power_info(struct > > port_data *port) > > > port->psy_current_max = 0; > > > break; > > > default: > > > - dev_err(dev, "Port %d: default case!\n", > > port->port_number); > > > + dev_dbg(dev, "Port %d: default case!\n", > > port->port_number); > > > port->psy_usb_type = POWER_SUPPLY_USB_TYPE_SDP; > > > } > > > > > > -- > > > 2.39.0.rc1.256.g54fd8350bd-goog > > > > >
[plain text this time] On Mon, Jan 2, 2023 at 2:19 PM Sebastian Reichel <sebastian.reichel@collabora.com> wrote: > Hi, > > Thanks, queued to power-supply's fixes branch. Awesome - thanks Sebastian! I'll pull from that branch when backporting to the Chrome OS kernels. https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/commit/?h=fixes&id=bb6bbf5df16201ece2dacabeb489fc2180c7cfcd cheers, grant > > -- Sebastian > > On Thu, Dec 29, 2022 at 11:53:55PM -0800, Grant Grundler wrote: > > Hi Sebastian, linux-pm folks, Benson, > > Can I get feedback on this patch please? > > > > I was just told another user feedback report had 70% of the dmesg buffer > > filled with the cros-usbpd-charger output. > > > > cheers, > > grant > > > > > > On Mon, Dec 12, 2022 at 1:49 PM Guenter Roeck <groeck@google.com> wrote: > > > > > On Mon, Dec 12, 2022 at 1:39 PM Grant Grundler <grundler@chromium.org> > > > wrote: > > > > > > > > This doesn't need to be printed every second as an error: > > > > ... > > > > <3>[17438.628385] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: > > > default case! > > > > <3>[17439.634176] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: > > > default case! > > > > <3>[17440.640298] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: > > > default case! > > > > ... > > > > > > > > Reduce priority from ERROR to DEBUG. > > > > > > > > Signed-off-by: Grant Grundler <grundler@chromium.org> > > > > > > Reviewed-by: Guenter Roeck <groeck@chromium.org> > > > > > > > > > > > --- > > > > drivers/power/supply/cros_usbpd-charger.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/power/supply/cros_usbpd-charger.c > > > b/drivers/power/supply/cros_usbpd-charger.c > > > > index cadb6a0c2cc7..b6c96376776a 100644 > > > > --- a/drivers/power/supply/cros_usbpd-charger.c > > > > +++ b/drivers/power/supply/cros_usbpd-charger.c > > > > @@ -276,7 +276,7 @@ static int cros_usbpd_charger_get_power_info(struct > > > port_data *port) > > > > port->psy_current_max = 0; > > > > break; > > > > default: > > > > - dev_err(dev, "Port %d: default case!\n", > > > port->port_number); > > > > + dev_dbg(dev, "Port %d: default case!\n", > > > port->port_number); > > > > port->psy_usb_type = POWER_SUPPLY_USB_TYPE_SDP; > > > > } > > > > > > > > -- > > > > 2.39.0.rc1.256.g54fd8350bd-goog > > > > > > >
diff --git a/drivers/power/supply/cros_usbpd-charger.c b/drivers/power/supply/cros_usbpd-charger.c index cadb6a0c2cc7..b6c96376776a 100644 --- a/drivers/power/supply/cros_usbpd-charger.c +++ b/drivers/power/supply/cros_usbpd-charger.c @@ -276,7 +276,7 @@ static int cros_usbpd_charger_get_power_info(struct port_data *port) port->psy_current_max = 0; break; default: - dev_err(dev, "Port %d: default case!\n", port->port_number); + dev_dbg(dev, "Port %d: default case!\n", port->port_number); port->psy_usb_type = POWER_SUPPLY_USB_TYPE_SDP; }
This doesn't need to be printed every second as an error: ... <3>[17438.628385] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: default case! <3>[17439.634176] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: default case! <3>[17440.640298] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: default case! ... Reduce priority from ERROR to DEBUG. Signed-off-by: Grant Grundler <grundler@chromium.org> --- drivers/power/supply/cros_usbpd-charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)