[edk2,2/2] Omap35xxPkg: move to ARM version of CpuExceptionHandlerLib

Message ID 1458137266-13831-2-git-send-email-ard.biesheuvel@linaro.org
State New
Headers show

Commit Message

Ard Biesheuvel March 16, 2016, 2:07 p.m.
Change our resolution for the previously unused CpuExceptionHandlerLib
from the null implementation to the newly added implementation specific
to AARCH64 and ARM. This is needed since our CpuDxe will start using it
in a subsequent patch.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---

This package does not actually refer to any modules that depend on
CpuExceptionHandlerLib, but for the sake of completeness, let's change
it anyway

 Omap35xxPkg/Omap35xxPkg.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.5.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm March 16, 2016, 2:56 p.m. | #1
On Wed, Mar 16, 2016 at 03:07:46PM +0100, Ard Biesheuvel wrote:
> Change our resolution for the previously unused CpuExceptionHandlerLib

> from the null implementation to the newly added implementation specific

> to AARCH64 and ARM. This is needed since our CpuDxe will start using it

> in a subsequent patch.

> 

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

> 

> This package does not actually refer to any modules that depend on

> CpuExceptionHandlerLib, but for the sake of completeness, let's change

> it anyway


Well, I would have thought it would make sense for the part-specific
(including CPU) bits to be defined by Omap35xxPkg rather than the
platform. But that doesn't need to change for this patch, so could you
just delete the line instead here if it's not used?

If you do so - for the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


>  Omap35xxPkg/Omap35xxPkg.dsc | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/Omap35xxPkg/Omap35xxPkg.dsc b/Omap35xxPkg/Omap35xxPkg.dsc

> index 5943e716c469..b719652b5a08 100644

> --- a/Omap35xxPkg/Omap35xxPkg.dsc

> +++ b/Omap35xxPkg/Omap35xxPkg.dsc

> @@ -43,7 +43,7 @@ [LibraryClasses.common]

>  

>    CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf

>    DefaultExceptioHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLib.inf

> -  CpuExceptionHandlerLib|MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLibNull.inf

> +  CpuExceptionHandlerLib|ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.inf

>    PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf

>  

>    RealTimeClockLib|EmbeddedPkg/Library/TemplateRealTimeClockLib/TemplateRealTimeClockLib.inf

> -- 

> 2.5.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Omap35xxPkg/Omap35xxPkg.dsc b/Omap35xxPkg/Omap35xxPkg.dsc
index 5943e716c469..b719652b5a08 100644
--- a/Omap35xxPkg/Omap35xxPkg.dsc
+++ b/Omap35xxPkg/Omap35xxPkg.dsc
@@ -43,7 +43,7 @@  [LibraryClasses.common]
 
   CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf
   DefaultExceptioHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLib.inf
-  CpuExceptionHandlerLib|MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLibNull.inf
+  CpuExceptionHandlerLib|ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.inf
   PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
 
   RealTimeClockLib|EmbeddedPkg/Library/TemplateRealTimeClockLib/TemplateRealTimeClockLib.inf