diff mbox

bhyve: caps: Log error message when CPU init fails

Message ID c770472c481e4737bcf4058183d6d2eab17058b9.1458340810.git.crobinso@redhat.com
State Accepted
Commit c770472c481e4737bcf4058183d6d2eab17058b9
Headers show

Commit Message

Cole Robinson March 18, 2016, 10:40 p.m. UTC 
virBhyveCapsInitCPU will raise a libvirt error; even though we treat
it as non-fatal we should log the actual message.
---
 src/bhyve/bhyve_capabilities.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.5.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Cole Robinson March 19, 2016, 7:27 p.m. UTC | #1 
On 03/19/2016 02:48 PM, Roman Bogorodskiy wrote:
>   Cole Robinson wrote:

> 

>> virBhyveCapsInitCPU will raise a libvirt error; even though we treat

>> it as non-fatal we should log the actual message.

>> ---

>>  src/bhyve/bhyve_capabilities.c | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c

>> index d2970a2..93faaed 100644

>> --- a/src/bhyve/bhyve_capabilities.c

>> +++ b/src/bhyve/bhyve_capabilities.c

>> @@ -97,7 +97,7 @@ virBhyveCapsBuild(void)

>>          goto error;

>>  

>>      if (virBhyveCapsInitCPU(caps, virArchFromHost()) < 0)

>> -            VIR_WARN("Failed to get host CPU");

>> +        VIR_WARN("Failed to get host CPU: %s", virGetLastErrorMessage());

>>  

>>      return caps;

> 

> ACK

> 

> Roman Bogorodskiy

> 


Thanks, pushed now

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
diff mbox

Patch

diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c
index d2970a2..93faaed 100644
--- a/src/bhyve/bhyve_capabilities.c
+++ b/src/bhyve/bhyve_capabilities.c
@@ -97,7 +97,7 @@  virBhyveCapsBuild(void)
         goto error;
 
     if (virBhyveCapsInitCPU(caps, virArchFromHost()) < 0)
-            VIR_WARN("Failed to get host CPU");
+        VIR_WARN("Failed to get host CPU: %s", virGetLastErrorMessage());
 
     return caps;