From patchwork Tue Mar 22 00:21:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Muckle X-Patchwork-Id: 64148 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp1746453lbc; Mon, 21 Mar 2016 17:21:34 -0700 (PDT) X-Received: by 10.66.138.74 with SMTP id qo10mr49021309pab.140.1458606094186; Mon, 21 Mar 2016 17:21:34 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ze7si6280553pac.34.2016.03.21.17.21.33; Mon, 21 Mar 2016 17:21:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=pass header.i=@linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758024AbcCVAVT (ORCPT + 29 others); Mon, 21 Mar 2016 20:21:19 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:32989 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753305AbcCVAVN (ORCPT ); Mon, 21 Mar 2016 20:21:13 -0400 Received: by mail-pf0-f181.google.com with SMTP id 4so153511239pfd.0 for ; Mon, 21 Mar 2016 17:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=X9qv6xYB9tyxuiuw7y+E3gluHeN7qqURLPb2wRAAqwI=; b=TThwTz7DY2ttLBamMNbrDRDdZRP1U3b4dJY0yPi6UAVCdLnAehfEBPiXMOQlGY5y57 6oYKU9LRtPDm5apCy0fdc8mayuKZ3BFdms33gZ1LGBKtaZFakX/DSZtuDbtwPWFF5I0v F50qrVQTe4UmvatHHUcukN0b1A1mAOpKdprtQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=X9qv6xYB9tyxuiuw7y+E3gluHeN7qqURLPb2wRAAqwI=; b=leIKvz33mI36vzqbLpzuQpjgCDiOdB/NPCw2xjH8POdJ5lAo961s+77rLUNw11sQ6k s2i5Oes+4KTjiqqrkOEyk/v+67cuyvJOUa7kk3B+gvnRBC3DC8ZLPb1OzYVubprcN1Hz G7bSv1WKE5puQ+jCJgFRhJV5y3Yg0p4Y4cU8VDozezjDSKw55Iot8BLDZZarCFkuG1pZ qXke0OsUroFYhGW1Bg+J1vNx1lbjR/y0aZtLiTUwYhpj2/fuj5Npl0KifBzyyemYJQyZ 3dSJRx0YzgTauEB7aRRccirE0r5lnRpfA6DGWp8D4JLVMS0SQfdEXhMUS49yOq2DJlDL OMoQ== X-Gm-Message-State: AD7BkJLGDU9KY2qPpvTCcpPFjEGVq3We1FOkdeuIxCxWsARgWH0pRMnnpsja/uwF6Oj6aqAr X-Received: by 10.98.67.67 with SMTP id q64mr49864238pfa.44.1458606073126; Mon, 21 Mar 2016 17:21:13 -0700 (PDT) Received: from sky.smuckle.net (cpe-75-80-155-7.san.res.rr.com. [75.80.155.7]) by smtp.gmail.com with ESMTPSA id 82sm43318418pfi.78.2016.03.21.17.21.11 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 21 Mar 2016 17:21:12 -0700 (PDT) From: Steve Muckle X-Google-Original-From: Steve Muckle To: Peter Zijlstra , Ingo Molnar Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Juri Lelli , Patrick Bellasi , Michael Turquette Subject: [PATCH 2/2] sched/fair: do not call cpufreq hook unless util changed Date: Mon, 21 Mar 2016 17:21:08 -0700 Message-Id: <1458606068-7476-2-git-send-email-smuckle@linaro.org> X-Mailer: git-send-email 2.4.10 In-Reply-To: <1458606068-7476-1-git-send-email-smuckle@linaro.org> References: <1458606068-7476-1-git-send-email-smuckle@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's no reason to call the cpufreq hook if the root cfs_rq utilization has not been modified. Signed-off-by: Steve Muckle --- kernel/sched/fair.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) -- 2.4.10 diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d418deb04049..af58e826cffe 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2826,20 +2826,21 @@ static inline int update_cfs_rq_load_avg(u64 now, struct cfs_rq *cfs_rq) { struct sched_avg *sa = &cfs_rq->avg; struct rq *rq = rq_of(cfs_rq); - int decayed, removed = 0; + int decayed, removed_load = 0, removed_util = 0; int cpu = cpu_of(rq); if (atomic_long_read(&cfs_rq->removed_load_avg)) { s64 r = atomic_long_xchg(&cfs_rq->removed_load_avg, 0); sa->load_avg = max_t(long, sa->load_avg - r, 0); sa->load_sum = max_t(s64, sa->load_sum - r * LOAD_AVG_MAX, 0); - removed = 1; + removed_load = 1; } if (atomic_long_read(&cfs_rq->removed_util_avg)) { long r = atomic_long_xchg(&cfs_rq->removed_util_avg, 0); sa->util_avg = max_t(long, sa->util_avg - r, 0); sa->util_sum = max_t(s32, sa->util_sum - r * LOAD_AVG_MAX, 0); + removed_util = 1; } decayed = __update_load_avg(now, cpu, sa, @@ -2850,7 +2851,8 @@ static inline int update_cfs_rq_load_avg(u64 now, struct cfs_rq *cfs_rq) cfs_rq->load_last_update_time_copy = sa->last_update_time; #endif - if (cpu == smp_processor_id() && &rq->cfs == cfs_rq) { + if (cpu == smp_processor_id() && &rq->cfs == cfs_rq && + (decayed || removed_util)) { unsigned long max = rq->cpu_capacity_orig; /* @@ -2873,7 +2875,7 @@ static inline int update_cfs_rq_load_avg(u64 now, struct cfs_rq *cfs_rq) min(sa->util_avg, max), max); } - return decayed || removed; + return decayed || removed_load; } /* Update task and its cfs_rq load average */