| Message ID | 56F243D7.1060508@linaro.org |
|---|---|
| State | New |
| Headers | show |
Maxim You missed some dates +++ b/platform/linux-generic/test/shmem/shmem_odp.c @@ -0,0 +1,74 @@ +/* Copyright (c) 2014, Linaro Limited + * All rights reserved. + * + * SPDX-License-Identifier: BSD-3-Clause + */ + +++ b/platform/linux-generic/test/shmem/shmem_odp.h @@ -0,0 +1,7 @@ +/* Copyright (c) 2014, Linaro Limited + * All rights reserved. + * + * SPDX-License-Identifier: BSD-3-Clause + */ + On 23 March 2016 at 03:20, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 03/23/16 03:04, Bill Fischofer wrote: > >> Maxim, I had added my review in my March 2nd reply. >> >> > CC shmem_linux.o > ../../../../../platform/linux-generic/test/shmem/shmem_linux.c:48:25: > fatal error: shmem_linux.h: No such file or directory > #include "shmem_linux.h" > > > So final fix for latest patch is: > --- a/platform/linux-generic/test/shmem/Makefile.am > +++ b/platform/linux-generic/test/shmem/Makefile.am > @@ -16,3 +16,5 @@ shmem_odp_CFLAGS = $(AM_CFLAGS) \ > $(INCODP) > shmem_odp_LDFLAGS = $(AM_LDFLAGS) > shmem_odp_LDADD = $(LIBCUNIT_COMMON) $(LIBODP) > + > +noinst_HEADERS = shmem_common.h shmem_linux.h shmem_odp.h > diff --git a/platform/linux-generic/test/shmem/shmem_linux.c > b/platform/linux-generic/test/shmem/shmem_linux.c > index 516bbe4..12266cc 100644 > --- a/platform/linux-generic/test/shmem/shmem_linux.c > +++ b/platform/linux-generic/test/shmem/shmem_linux.c > @@ -1,4 +1,4 @@ > -/* Copyright (c) 2014, Linaro Limited > +/* Copyright (c) 2016, Linaro Limited > * All rights reserved. > * > * SPDX-License-Identifier: BSD-3-Clause > > > Merged with corresponding fixes. > > Maxim. > > > > On Mon, Mar 21, 2016 at 7:52 AM, Maxim Uvarov <maxim.uvarov@linaro.org >> <mailto:maxim.uvarov@linaro.org>> wrote: >> >> does somebody also want to review that test? >> >> Maxim. >> >> >> On 03/02/16 17:52, Christophe Milard wrote: >> >> (Note: requires: linux-generic: shmem: odp scope in /dev/shmem) >> Adding a platform side test to test sharing memory between ODP >> and linux. >> This test is more interresting for its side effects: >> *first complete test on the platform side building ODP and >> platform >> programs (other platform tests so far were just wrappers to >> generic >> platform-agnostic test) >> *tests that the shared memory device name (under /dev/shm/) is >> scoped >> (under linux) >> >> Christophe Milard (2): >> linux-generic: test: adding odp includes >> linux-generic: test: ODP_SHM_PROC test >> >> platform/linux-generic/m4/configure.m4 | 1 + >> platform/linux-generic/test/Makefile.am | 4 +- >> platform/linux-generic/test/Makefile.inc | 16 +++ >> platform/linux-generic/test/shmem/.gitignore | 2 + >> platform/linux-generic/test/shmem/Makefile.am | 18 +++ >> platform/linux-generic/test/shmem/shmem.h | 21 +++ >> platform/linux-generic/test/shmem/shmem_common.h | 23 ++++ >> platform/linux-generic/test/shmem/shmem_linux.c | 156 >> +++++++++++++++++++++++ >> platform/linux-generic/test/shmem/shmem_linux.h | 9 ++ >> platform/linux-generic/test/shmem/shmem_odp.c | 74 >> +++++++++++ >> platform/linux-generic/test/shmem/shmem_odp.h | 7 + >> 11 files changed, 330 insertions(+), 1 deletion(-) >> create mode 100644 platform/linux-generic/test/Makefile.inc >> create mode 100644 platform/linux-generic/test/shmem/.gitignore >> create mode 100644 platform/linux-generic/test/shmem/Makefile.am >> create mode 100644 platform/linux-generic/test/shmem/shmem.h >> create mode 100644 >> platform/linux-generic/test/shmem/shmem_common.h >> create mode 100644 >> platform/linux-generic/test/shmem/shmem_linux.c >> create mode 100644 >> platform/linux-generic/test/shmem/shmem_linux.h >> create mode 100644 platform/linux-generic/test/shmem/shmem_odp.c >> create mode 100644 platform/linux-generic/test/shmem/shmem_odp.h >> >> >> >> > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
Thanks. See you next week :-) On 23 Mar 2016 14:58, "Mike Holmes" <mike.holmes@linaro.org> wrote: > Maxim You missed some dates > > +++ b/platform/linux-generic/test/shmem/shmem_odp.c > @@ -0,0 +1,74 @@ > +/* Copyright (c) 2014, Linaro Limited > + * All rights reserved. > + * > + * SPDX-License-Identifier: BSD-3-Clause > + */ > + > > +++ b/platform/linux-generic/test/shmem/shmem_odp.h > @@ -0,0 +1,7 @@ > +/* Copyright (c) 2014, Linaro Limited > + * All rights reserved. > + * > + * SPDX-License-Identifier: BSD-3-Clause > + */ > + > > > > On 23 March 2016 at 03:20, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > >> On 03/23/16 03:04, Bill Fischofer wrote: >> >>> Maxim, I had added my review in my March 2nd reply. >>> >>> >> CC shmem_linux.o >> ../../../../../platform/linux-generic/test/shmem/shmem_linux.c:48:25: >> fatal error: shmem_linux.h: No such file or directory >> #include "shmem_linux.h" >> >> >> So final fix for latest patch is: >> --- a/platform/linux-generic/test/shmem/Makefile.am >> +++ b/platform/linux-generic/test/shmem/Makefile.am >> @@ -16,3 +16,5 @@ shmem_odp_CFLAGS = $(AM_CFLAGS) \ >> $(INCODP) >> shmem_odp_LDFLAGS = $(AM_LDFLAGS) >> shmem_odp_LDADD = $(LIBCUNIT_COMMON) $(LIBODP) >> + >> +noinst_HEADERS = shmem_common.h shmem_linux.h shmem_odp.h >> diff --git a/platform/linux-generic/test/shmem/shmem_linux.c >> b/platform/linux-generic/test/shmem/shmem_linux.c >> index 516bbe4..12266cc 100644 >> --- a/platform/linux-generic/test/shmem/shmem_linux.c >> +++ b/platform/linux-generic/test/shmem/shmem_linux.c >> @@ -1,4 +1,4 @@ >> -/* Copyright (c) 2014, Linaro Limited >> +/* Copyright (c) 2016, Linaro Limited >> * All rights reserved. >> * >> * SPDX-License-Identifier: BSD-3-Clause >> >> >> Merged with corresponding fixes. >> >> Maxim. >> >> >> >> On Mon, Mar 21, 2016 at 7:52 AM, Maxim Uvarov <maxim.uvarov@linaro.org >>> <mailto:maxim.uvarov@linaro.org>> wrote: >>> >>> does somebody also want to review that test? >>> >>> Maxim. >>> >>> >>> On 03/02/16 17:52, Christophe Milard wrote: >>> >>> (Note: requires: linux-generic: shmem: odp scope in /dev/shmem) >>> Adding a platform side test to test sharing memory between ODP >>> and linux. >>> This test is more interresting for its side effects: >>> *first complete test on the platform side building ODP and >>> platform >>> programs (other platform tests so far were just wrappers to >>> generic >>> platform-agnostic test) >>> *tests that the shared memory device name (under /dev/shm/) is >>> scoped >>> (under linux) >>> >>> Christophe Milard (2): >>> linux-generic: test: adding odp includes >>> linux-generic: test: ODP_SHM_PROC test >>> >>> platform/linux-generic/m4/configure.m4 | 1 + >>> platform/linux-generic/test/Makefile.am | 4 +- >>> platform/linux-generic/test/Makefile.inc | 16 +++ >>> platform/linux-generic/test/shmem/.gitignore | 2 + >>> platform/linux-generic/test/shmem/Makefile.am | 18 +++ >>> platform/linux-generic/test/shmem/shmem.h | 21 +++ >>> platform/linux-generic/test/shmem/shmem_common.h | 23 ++++ >>> platform/linux-generic/test/shmem/shmem_linux.c | 156 >>> +++++++++++++++++++++++ >>> platform/linux-generic/test/shmem/shmem_linux.h | 9 ++ >>> platform/linux-generic/test/shmem/shmem_odp.c | 74 >>> +++++++++++ >>> platform/linux-generic/test/shmem/shmem_odp.h | 7 + >>> 11 files changed, 330 insertions(+), 1 deletion(-) >>> create mode 100644 platform/linux-generic/test/Makefile.inc >>> create mode 100644 platform/linux-generic/test/shmem/.gitignore >>> create mode 100644 >>> platform/linux-generic/test/shmem/Makefile.am >>> create mode 100644 platform/linux-generic/test/shmem/shmem.h >>> create mode 100644 >>> platform/linux-generic/test/shmem/shmem_common.h >>> create mode 100644 >>> platform/linux-generic/test/shmem/shmem_linux.c >>> create mode 100644 >>> platform/linux-generic/test/shmem/shmem_linux.h >>> create mode 100644 >>> platform/linux-generic/test/shmem/shmem_odp.c >>> create mode 100644 >>> platform/linux-generic/test/shmem/shmem_odp.h >>> >>> >>> >>> >> > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs > "Work should be fun and collaborative, the rest follows" > > >
--- a/platform/linux-generic/test/shmem/Makefile.am +++ b/platform/linux-generic/test/shmem/Makefile.am @@ -16,3 +16,5 @@ shmem_odp_CFLAGS = $(AM_CFLAGS) \ $(INCODP) shmem_odp_LDFLAGS = $(AM_LDFLAGS) shmem_odp_LDADD = $(LIBCUNIT_COMMON) $(LIBODP) + +noinst_HEADERS = shmem_common.h shmem_linux.h shmem_odp.h diff --git a/platform/linux-generic/test/shmem/shmem_linux.c b/platform/linux-generic/test/shmem/shmem_linux.c index 516bbe4..12266cc 100644 --- a/platform/linux-generic/test/shmem/shmem_linux.c +++ b/platform/linux-generic/test/shmem/shmem_linux.c @@ -1,4 +1,4 @@ -/* Copyright (c) 2014, Linaro Limited +/* Copyright (c) 2016, Linaro Limited * All rights reserved. * * SPDX-License-Identifier: BSD-3-Clause